Bug 1358937

Summary: Review Request: perl-HTML-LinkList - Create a 'smart' list of HTML links
Product: [Fedora] Fedora Reporter: Emmanuel Seyman <emmanuel>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-24 12:54:20 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Emmanuel Seyman 2016-07-21 20:10:13 UTC 
Spec URL: http://people.parinux.org/~seyman/fedora/perl-HTML-LinkList/perl-HTML-LinkList.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-HTML-LinkList/perl-HTML-LinkList-0.1701-1.fc24.src.rpm
Description:
This module contains a number of functions for taking sets of URLs and
labels and creating suitably formatted HTML. These links are "smart"
because, if given the url of the current page, if any of the links in the
list equal it, that item in the list will be formatted as a special label,
not as a link; this is a Good Thing, since the user would be confused by
clicking on a link back to the current page.

Fedora Account System Username: eseyman
Rpmlint Output:
perl-HTML-LinkList.src: W: spelling-error %description -l en_US url -> URL, curl, purl
1 packages and 1 specfiles checked; 0 errors, 1 warnings.
Comment 1 Jitka Plesnikova 2016-07-22 14:16:41 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-HTML-LinkList-0.1701-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(:MODULE_COMPAT_5.24.0)
      1 perl(Data::Dumper)
      1 perl(Exporter)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-HTML-LinkList-0.1701-1.fc25.noarch.rpm | sort | uniq -c
      1 perl(HTML::LinkList) = 0.1701
      1 perl-HTML-LinkList = 0.1701-1.fc25
Binary provides are Ok.

$ rpmlint ./perl-HTML-LinkList*
perl-HTML-LinkList.src: W: spelling-error %description -l en_US url -> URL, curl, purl
perl-HTML-LinkList.noarch: W: spelling-error %description -l en_US url -> URL, curl, purl
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Rpmlint is ok

The package looks good.
Approved
Comment 2 Emmanuel Seyman 2016-07-24 12:54:20 UTC 
When I tried to request a repo for this package, I got an error message "package already exists". It turns out this package has been in Fedora for a number of years (the review bug is bug #487809) and that I am the owner of the package.

Please don't ask me why I didn't see this earlier. I have no idea.

Jikta, I'm sorry for the useless review. I owe you a beer should we ever meet in person.

*** This bug has been marked as a duplicate of bug 487809 ***