Red Hat Bugzilla – Bug 487809
Review Request: perl-HTML-LinkList - Create a 'smart' list of HTML links
Last modified: 2016-07-24 08:54:20 EDT
Spec URL: http://fedorapeople.org/~cweyl/review/perl-HTML-LinkList.spec SRPM URL: http://fedorapeople.org/~cweyl/review/perl-HTML-LinkList-0.1503-1.fc10.src.rpm Description: This module contains a number of functions for taking sets of URLs and labels and creating suitably formatted HTML. These links are "smart" because, if given the url of the current page, if any of the links in the list equal it, that item in the list will be formatted as a special label, not as a link; this is a Good Thing, since the user would be confused by clicking on a link back to the current page. While many website systems have plugins for "smart" navbars, they are specialized for that system only, and can't be reused elsewhere, forcing people to reinvent the wheel. I hereby present one wheel, free to be reused by anybody; just the simple functions, a backend, which can be plugged into whatever system you want.The default format for the HTML is to make an unordered list, but there are many options, enabling one to have a flatter layout with any separators you desire, or a more complicated list with differing formats for different levels. Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1207061 *rt-0.05
Review: + package builds in mock (rawhide i386). koji build=> http://koji.fedoraproject.org/koji/taskinfo?taskID=1207061 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 57e79ea9a15e57864042d3645651530c HTML-LinkList-0.1503.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs All tests successful. Files=9, Tests=61, 1 wallclock secs ( 0.05 usr 0.02 sys + 1.05 cusr 0.09 csys = 1.21 CPU) + Package perl-HTML-LinkList-0.1503-1.fc11-noarch -> Provides: perl(HTML::LinkList) = 0.1503 Requires: perl(Data::Dumper) perl(Exporter) perl(strict) perl(warnings) APPROVED.
New Package CVS Request ======================= Package Name: perl-HTML-LinkList Short Description: Create a 'smart' list of HTML links Owners: cweyl Branches: F-9 F-10 devel InitialCC: perl-sig
*** Bug 487851 has been marked as a duplicate of this bug. ***
cvs done.
Thanks for the review! :-)
*** Bug 1358937 has been marked as a duplicate of this bug. ***