Bug 1360647

Summary:	gfapi: deprecate the rdma support for management connections
Product:	[Community] GlusterFS	Reporter:	Prasanna Kumar Kalever <prasanna.kalever>
Component:	libgfapi	Assignee:	Prasanna Kumar Kalever <prasanna.kalever>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Sudhir D <sdharane>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, ndevos
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.9.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1376667 (view as bug list)		Environment:
Last Closed:	2017-03-27 18:21:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1376667

Description Prasanna Kumar Kalever 2016-07-27 08:52:52 UTC

Description of problem:
Improve glfs_set_volfile_server();

RDMA transport was never supported for management connection before, but glfs_set_volfile_server() allowed it and the gluster code silently fall back to tcp with out a warning, this gave a chance to people assume that mgmt connection supports rdma along with tcp and unix.

We need to deprecate the rdma support by stating to splash warning at the usage.

Also add better defense code on port and transport;


Version-Release number of selected component (if applicable):
mainline

Comment 1 Vijay Bellur 2016-07-27 09:06:59 UTC

REVIEW: http://review.gluster.org/15026 (gfapi: deprecate rdma support for management connections) posted (#1) for review on master by Prasanna Kumar Kalever (pkalever)

Comment 2 Vijay Bellur 2016-07-27 15:45:27 UTC

COMMIT: http://review.gluster.org/15026 committed in master by Niels de Vos (ndevos) 
------
commit 6e78a0dda9343d75674a12b7e1a1e8e59e17c78c
Author: Prasanna Kumar Kalever <prasanna.kalever>
Date:   Wed Jul 27 14:23:23 2016 +0530

    gfapi: deprecate rdma support for management connections
    
    RDMA transport was never supported for management connection before, but
    glfs_set_volfile_server() allowed rdma transport type due to lack of defense
    code and the glusterfs_mgmt_init() code silently fall back to tcp with out
    any warnings, this gave a chance for assumtions that mgmt connection also
    supports rdma along with tcp and unix.
    
    This patch deprecates the rdma support by warning at its usage.
    
    Change-Id: I0ad99d9851e05ff84ba4b6a3534a984bcc7e2ed7
    BUG: 1360647
    Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever>
    Reviewed-on: http://review.gluster.org/15026
    Tested-by: Prasanna Kumar Kalever <pkalever>
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jdarcy>
    Reviewed-by: Niels de Vos <ndevos>

Comment 3 Niels de Vos 2016-08-02 12:19:55 UTC

*** Bug 1360646 has been marked as a duplicate of this bug. ***

Comment 4 Shyamsundar 2017-03-27 18:21:04 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.9.0, please open a new bug report.

glusterfs-3.9.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://lists.gluster.org/pipermail/gluster-users/2016-November/029281.html
[2] https://www.gluster.org/pipermail/gluster-users/