Bug 1360915
| Summary: | --forceremove within rescan-scsi-bus.sh not working as expected | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | John Pittman <jpittman> |
| Component: | sg3_utils | Assignee: | Gris Ge <fge> |
| Status: | CLOSED ERRATA | QA Contact: | David Jež <djez> |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 7.2 | CC: | djez, isenfeld, jpittman, qe-baseos-apps |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | sg3_utils-1.37-12.el7 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2017-08-01 18:56:47 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Hi John Pittman, Upstream decideded to change help message instead of change action of `forceremove`, and I would like to keep that way in RHEL 7. Is that OK to you? Hi Gris. Yes, that's fine with me. Help text of forceremove changed: old: --forceremove: Remove and readd every device (DANGEROUS) new: --forceremove: Remove stale devices (DANGEROUS) Help text of forcerescan changed: old: --forcerescan: Rescan existing devices new: --forcerescan: Remove and readd existing devices (DANGEROUS) Patch submitted to upstream: https://github.com/hreinecke/sg3_utils/pull/16 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2017:2048 |
Description of problem: When using rescan-scsi-bus.sh with the --forceremove option, expectation, taken from the --help of the command, is to "Remove and readd every device". Currently, the devices are removed, but we do not readd. Added additional line to ensure readd attempt. Version-Release number of selected component (if applicable): sg3_utils-libs-1.37-5.el7.x86_64 sg3_utils-1.37-5.el7.x86_64 How reproducible: Run 'rescan-scsi-bus.sh --forceremove' Observe devices are removed and not readded Actual results: Devices are removed Expected results: Devices should be removed and readded as mentioned in the help Additional info: Patch to enable readding: diff --git a/scripts/rescan-scsi-bus.sh b/scripts/rescan-scsi-bus.sh index fad4868..f2ae310 100755 --- a/scripts/rescan-scsi-bus.sh +++ b/scripts/rescan-scsi-bus.sh @@ -499,6 +499,7 @@ dolunscan() fi echo 1 > /sys/class/scsi_device/${host}:${channel}:${id}:${lun}/device/delete sleep 0.02 + echo "scsi add-single-device $devnr" > /proc/scsi/scsi else echo "scsi remove-single-device $devnr" > /proc/scsi/scsi if test $RC -eq 1 -o $lun -eq 0 ; then As a note, I submitted the patch upstream on github but never got response. https://github.com/hreinecke/sg3_utils/pull/5/commits/becd6d75acecc4e816e2e22f7cf649c24b9bd1ac