Description of problem:

When using rescan-scsi-bus.sh with the --forceremove option, expectation, taken from the --help of the command, is to "Remove and readd every device". Currently, the devices are removed, but we do not readd. Added additional line to ensure readd attempt.

Version-Release number of selected component (if applicable):

sg3_utils-libs-1.37-5.el7.x86_64
sg3_utils-1.37-5.el7.x86_64

How reproducible:

Run 'rescan-scsi-bus.sh --forceremove'
Observe devices are removed and not readded

Actual results:

Devices are removed

Expected results:

Devices should be removed and readded as mentioned in the help

Additional info:

Patch to enable readding:

diff --git a/scripts/rescan-scsi-bus.sh b/scripts/rescan-scsi-bus.sh
index fad4868..f2ae310 100755
--- a/scripts/rescan-scsi-bus.sh
+++ b/scripts/rescan-scsi-bus.sh
@@ -499,6 +499,7 @@ dolunscan()
         fi
         echo 1 > /sys/class/scsi_device/${host}:${channel}:${id}:${lun}/device/delete
         sleep 0.02
+       echo "scsi add-single-device $devnr" > /proc/scsi/scsi
       else
         echo "scsi remove-single-device $devnr" > /proc/scsi/scsi
         if test $RC -eq 1 -o $lun -eq 0 ; then

As a note, I submitted the patch upstream on github but never got response.
https://github.com/hreinecke/sg3_utils/pull/5/commits/becd6d75acecc4e816e2e22f7cf649c24b9bd1ac