Bug 1361012

Summary: Provider summary page has an additional authentication when editing Provider details.
Product: Red Hat CloudForms Management Engine Reporter: Einat Pacifici <epacific>
Component: UI - OPSAssignee: Yaacov Zamir <yzamir>
Status: CLOSED CURRENTRELEASE QA Contact: Jaroslav Henner <jhenner>
Severity: medium Docs Contact:
Priority: high    
Version: 5.6.0CC: dron, hkataria, jhardy, mpovolny, obarenbo, simaishi, yzamir
Target Milestone: GAKeywords: TestOnly
Target Release: 5.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: container
Fixed In Version: 5.8.0.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1370576 1391265 (view as bug list) Environment:
Last Closed: 2017-06-12 16:15:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1370576, 1391265    
Attachments:
Description Flags
evm.log and two screenshots none

Description Einat Pacifici 2016-07-28 07:09:10 UTC
Created attachment 1184894 [details]
evm.log and two screenshots

Description of problem:
When editing a container Provider, an additional value named: Default Authentication appears in the Providers --> Status table. 

Version-Release number of selected component (if applicable):
5.6.1

How reproducible:
Always

Steps to Reproduce:
1. Add a new Container Provider to CFME
2. Look at status table of provider (example attached: Provider_BeforeEdit.png)
3. Edit the new provider (e.g. change provider name)
4. Look at status table of provider (example attached: Provider_AfterEdit.png)

Actual results:
A new row appears in the table: Default Authentication - Valid

Expected results:
No new row should appear. 

Additional info:
Two screenshots attached + evm.log

Comment 2 Yaacov Zamir 2016-07-28 07:16:19 UTC
Submited upstream:
https://github.com/ManageIQ/manageiq/pull/9947

Comment 3 Yaacov Zamir 2016-08-09 08:45:08 UTC
merged:
https://github.com/ManageIQ/manageiq/pull/9947

Comment 6 Jaroslav Henner 2016-10-18 18:50:53 UTC
Default Authentication still appears after the edit of the provider name.
cfme-5.7.0.0-1.el7cf.x86_64

Comment 7 Yaacov Zamir 2016-10-25 07:06:58 UTC
Submitted upstream:
https://github.com/ManageIQ/manageiq/pull/11504

Comment 8 CFME Bot 2016-11-01 19:06:05 UTC
New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/062f09401268ee52919091914c361a484c75294f

commit 062f09401268ee52919091914c361a484c75294f
Author:     Oleg Barenboim <chessbyte>
AuthorDate: Tue Nov 1 15:03:11 2016 -0400
Commit:     Oleg Barenboim <chessbyte>
CommitDate: Tue Nov 1 15:03:44 2016 -0400

    Merge pull request #11504 from yaacov/remove-extra-default-authentication-for-ems-containers
    
    Remove the extra "default" authentication created when editing a container provider.
    (cherry picked from commit bfe87e83aaaa2c5318f524a788a8fcab4a946424)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1361012
    https://bugzilla.redhat.com/show_bug.cgi?id=1389278

 app/controllers/mixins/ems_common_angular.rb        | 21 +++++++++++----------
 .../providers/kubernetes/container_manager_mixin.rb |  2 +-
 app/models/mixins/authentication_mixin.rb           |  6 +++---
 spec/controllers/ems_common_controller_spec.rb      |  6 ++++++
 4 files changed, 21 insertions(+), 14 deletions(-)

Comment 9 Yaacov Zamir 2016-11-02 05:45:56 UTC
Merged
https://github.com/ManageIQ/manageiq/pull/11504

Comment 12 Jaroslav Henner 2017-03-07 12:27:44 UTC
The new row didn't appear.