Bug 1370576 - Provider summary page has an additional authentication when editing Provider details.
Summary: Provider summary page has an additional authentication when editing Provider ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.6.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: GA
: 5.6.3
Assignee: Yaacov Zamir
QA Contact: Einat Pacifici
URL:
Whiteboard: container
Depends On: 1361012
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-26 15:44 UTC by Satoe Imaishi
Modified: 2022-07-09 07:58 UTC (History)
8 users (show)

Fixed In Version: 5.6.3.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1361012
Environment:
Last Closed: 2016-11-30 19:53:19 UTC
Category: ---
Cloudforms Team: Container Management
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
provider showing line. (159.88 KB, image/png)
2016-09-24 14:34 UTC, Einat Pacifici
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2016:2839 0 normal SHIPPED_LIVE Important: CFME 5.6.3 security, bug fix, and enhancement update 2016-12-01 00:51:49 UTC

Comment 2 Federico Simoncelli 2016-08-29 13:55:10 UTC
Yaacov should this be moved to POST?

Comment 3 Yaacov Zamir 2016-08-29 14:28:30 UTC
Backported:
https://github.com/ManageIQ/manageiq/pull/9947

Comment 4 Einat Pacifici 2016-09-24 14:34:00 UTC
Created attachment 1204389 [details]
provider showing line.

Bug returned to dev. After editing a new provider, the same line appears: Default Authentication - None. 
Screenshot attached.

Comment 5 Einat Pacifici 2016-09-24 14:35:00 UTC
Bug failed. Line is still showing up. new screenshot attached.

Comment 8 CFME Bot 2016-11-01 19:06:15 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/a1147c93451a834c6476151f7a30e82297ee3f5b

commit a1147c93451a834c6476151f7a30e82297ee3f5b
Author:     yaacov <kobi.zamir>
AuthorDate: Sun Sep 25 15:38:27 2016 +0300
Commit:     yaacov <kobi.zamir>
CommitDate: Tue Nov 1 11:21:16 2016 +0200

    Reove the extra "default" authentication created when editing a container provider.
    
    PR #9947 solved the removal of the extra "default" authentications only in cases where the
    params[:default_password] was not blank (this is not always true), this PR fixes that,
    and remove the extra authenication in all the cases the where the external manegment system
    is container manager.
    
    Bugzilla:
    https://bugzilla.redhat.com/show_bug.cgi?id=1370576
    https://bugzilla.redhat.com/show_bug.cgi?id=1389278

 app/controllers/mixins/ems_common_angular.rb        | 21 +++++++++++----------
 .../providers/kubernetes/container_manager_mixin.rb |  2 +-
 app/models/mixins/authentication_mixin.rb           |  6 +++---
 spec/controllers/ems_common_controller_spec.rb      |  6 ++++++
 4 files changed, 21 insertions(+), 14 deletions(-)

Comment 9 Federico Simoncelli 2016-11-02 10:00:55 UTC
Yaacov should this be in POST?

Comment 10 Yaacov Zamir 2016-11-02 10:08:49 UTC
> Yaacov should this be in POST?

This BZ is on Darga, and it's not backported yet.

Comment 11 Yaacov Zamir 2016-11-03 04:15:25 UTC
a PR specific for Darga submited upstream:
https://github.com/ManageIQ/manageiq/pull/12367

Comment 12 Yaacov Zamir 2016-11-04 05:57:55 UTC
merged:
https://github.com/ManageIQ/manageiq/pull/12367

Comment 13 Einat Pacifici 2016-11-15 09:14:23 UTC
Verified. 
Steps: 
Modified Provider name - Save new details. 
View Provider summary page. 
Results: 
No new additional line with "Default Authentication" seen.

Comment 15 errata-xmlrpc 2016-11-30 19:53:19 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2839.html


Note You need to log in before you can comment on or make changes to this bug.