Bug 1361584
| Summary: | Review Request: rubygem-spring-watcher-listen - Makes spring watch files using the listen gem | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jun Aruga <jaruga> |
| Component: | Package Review | Assignee: | Vít Ondruch <vondruch> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, vondruch |
| Target Milestone: | --- | Flags: | vondruch:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | rubygem-spring-watcher-listen-2.0.0-1.fc26 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-09-26 07:52:13 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jun Aruga
2016-07-29 12:53:06 UTC
Taking this for a review. I could also succeed the build without latest spring. Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=15059593 * Errors in test suite output
- There are worrying errors reported in test suite output, although the test
suite passes. What is the reason for them?
- Actually they appear randomly so probably not of concern.g
* Unnecessary BR
- BR: rubygem(rb-inotify) is not needed anymore, since updated
version of listen pulls this automatically.
- BR: rubygem(minitest) is pulled in via ActiveSupport.
* Keep the disabled test file
- I typically prefer to rename the test files I want to disable, since I can
later review them if needed. But this is just a minor nit.
Since all the points above are just minor nits I APPROVE the package.
> * Errors in test suite output I was not sure the error message's reason. So, I asking the upstream, just in case, though I am going to submit this package. https://github.com/jonleighton/spring-watcher-listen/issues/12 > * Unnecessary BR Updated. > * Keep the disabled test file Updated. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-spring-watcher-listen This is already in Fedora as far as I can tell => closing the ticket. |