Spec URL: http://people.redhat.com/jaruga/git/rubygem-spring-watcher-listen/rubygem-spring-watcher-listen.spec SRPM URL: http://people.redhat.com/jaruga/git/rubygem-spring-watcher-listen/rubygem-spring-watcher-listen-2.0.0-1.fc26.src.rpm Description: Makes spring watch files using the listen gem Fedora Account System Username: jaruga Koji: None Copr: https://copr.fedorainfracloud.org/coprs/vondruch/ror5/package/rubygem-spring-watcher-listen/
Taking this for a review.
I could also succeed the build without latest spring. Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=15059593
* Errors in test suite output - There are worrying errors reported in test suite output, although the test suite passes. What is the reason for them? - Actually they appear randomly so probably not of concern.g * Unnecessary BR - BR: rubygem(rb-inotify) is not needed anymore, since updated version of listen pulls this automatically. - BR: rubygem(minitest) is pulled in via ActiveSupport. * Keep the disabled test file - I typically prefer to rename the test files I want to disable, since I can later review them if needed. But this is just a minor nit. Since all the points above are just minor nits I APPROVE the package.
> * Errors in test suite output I was not sure the error message's reason. So, I asking the upstream, just in case, though I am going to submit this package. https://github.com/jonleighton/spring-watcher-listen/issues/12 > * Unnecessary BR Updated. > * Keep the disabled test file Updated.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-spring-watcher-listen
This is already in Fedora as far as I can tell => closing the ticket.