Bug 1361768
| Summary: | python-django-pyscss: Provide a Python 3 subpackage | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Viktorin (pviktori) <pviktori> | ||||||||
| Component: | python-django-pyscss | Assignee: | Matthias Runge <mrunge> | ||||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | rawhide | CC: | jberan, lbalhar, mrunge, torsava | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2016-08-30 12:16:48 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | |||||||||||
| Bug Blocks: | 1285816, 1312032 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Petr Viktorin (pviktori)
2016-07-30 09:04:03 UTC
Created attachment 1186155 [details]
Spec file patch to provide Python 3 subpackage
Created attachment 1186156 [details]
Updated spec file
Changelog correction
Created attachment 1187101 [details] Updated spec file Hi Tomáš, may I ask you to review the updated spec file patch which I have adjusted according to the request of Matthias (bug #1311552)? Thank you. Hi Jan!
The patch looks great, there's just one tiny detail:
In the original spec file, in the %prep section there's the following:
# Remove bundled egg-info
rm -rf %{pypi_name}.egg-info
That's usually a good idea, because the .egg-info gets generated anew during the build. Therefore I suggest leaving this line in the spec file.
Apart from that, everything looks superb!
Hi Tomáš, thanks for your review. As I understand from the recommendation of Matthias (bug #1311552), if %autosetup replaces %setup then "rm -rf %{pypi_name}.egg-info" command is not required any more. Oh, I did not know that, my apologies! In that case, the patch looks good to me! Jan, Tomas, %autosetup replaces %setup. I don't remember the reasons. Removing the upstream provided egg-info is discouraged anyways. That was a change around 2 years ago, driven by kchamart, but neither he nor me remember the the reasons for that anymore. The recommendation to remove egg-info has been removed from python packaging guidelines then. Difference between %setup and %autosetup is, that autosetup applies patches listed in %patch???. Hello Matthias. Yes, differences between %setup and %autosetup are: - %autosetup applies patches (Patch0, Patch1 ...) automatically - %autosetup has option -q (quiet) enabled by default If maintainer has nothing against, we can push this reviewed patch after a week. (In reply to Lumír Balhar from comment #10) > If maintainer has nothing against, we can push this reviewed patch after a > week. Which patch are you speaking of? The last patch is marked obsolete here. (In reply to Matthias Runge from comment #11) > (In reply to Lumír Balhar from comment #10) > > If maintainer has nothing against, we can push this reviewed patch after a > > week. > > Which patch are you speaking of? The last patch is marked obsolete here. I believe you are mistaken, the last patch [0] is not obsoleted. [0] https://bugzilla.redhat.com/attachment.cgi?id=1187101 committed the patch and fixed the build afterwards, mrunge's python-django-pyscss-2.0.2-4.fc26 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=795604 Thanks! |