Bug 1311552 - python-django-pipeline: Provide a Python 3 subpackage
Summary: python-django-pipeline: Provide a Python 3 subpackage
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-django-pipeline
Version: 25
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Matthias Runge
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3 PY3PATCH-AVAILABLE
TreeView+ depends on / blocked
 
Reported: 2016-02-24 12:56 UTC by Tomas Orsava
Modified: 2016-08-01 16:52 UTC (History)
5 users (show)

Fixed In Version: python-django-pipeline-1.6.8-1.fc26
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-08-01 16:52:09 UTC


Attachments (Terms of Use)
updated spec file (4.52 KB, patch)
2016-07-28 16:10 UTC, Jan Beran
no flags Details | Diff
spec file correction (4.64 KB, patch)
2016-07-29 06:37 UTC, Jan Beran
no flags Details | Diff
Correction of %doc and %license macros. (4.67 KB, patch)
2016-07-29 13:46 UTC, Jan Beran
no flags Details | Diff

Description Tomas Orsava 2016-02-24 12:56:04 UTC
Upstream, this software supports Python 3. Please provide a Python 3
package for Fedora.


According to the Python packaging guidelines [0], software must be
packaged for Python 3 if upstream supports it.
The guidelines give detailed information on how to do this, and even
provide an example spec file [1].

The current best practice is to provide subpackages for the two Python
versions (called "Common SRPM" in the guidelines). Alternatively, if
nothing depends on your Python2 package, you can just switch to Python 3
entirely.

It's fine to do this in Rawhide only.


If anything is unclear, or if you need any kind of assistance with the
porting, you can ask on IRC (#fedora-python on Freenode), or reply here.
We'll be happy to help!


[0] https://fedoraproject.org/wiki/Packaging:Python
[1] https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file

Comment 1 Fedora Admin XMLRPC Client 2016-02-24 16:01:50 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 2 Fedora Admin XMLRPC Client 2016-02-24 19:39:05 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 3 Jan Kurik 2016-07-26 04:48:11 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle.
Changing version to '25'.

Comment 4 Jan Beran 2016-07-28 16:10:19 UTC
Created attachment 1185180 [details]
updated spec file

Patched specfile:
- update to version 1.6.8
- url and source update
- modernized specfile with Python 3 packaging

Comment 5 Jan Beran 2016-07-29 06:37:18 UTC
Created attachment 1185398 [details]
spec file correction

Correction of missing python_provide scripts

Comment 6 Tomas Orsava 2016-07-29 10:38:09 UTC
Hi Jan!
The patch looks good to me!

There's just a very minor nitpick: The LICENSE file should go to the %license macro instead of the %doc macro now. Apart from that it looks perfect.

Comment 7 Jan Beran 2016-07-29 13:46:52 UTC
Created attachment 1185563 [details]
Correction of %doc and %license macros.

Correction of %doc and %license macros in the spec file.

Comment 8 Jan Beran 2016-07-29 17:24:10 UTC
Hi Tomáš, thank you for the review and your hint. I have corrected the specfile. May I ask you to check again?

Comment 9 Tomas Orsava 2016-08-01 09:42:36 UTC
Hi Jan, looks good to me!

Comment 10 Jan Beran 2016-08-01 12:43:21 UTC
Tomáš, thank you for the review.

Hi Matthias, the attached spec file is ready to provide the Python 3 subpackage.

Comment 11 Matthias Runge 2016-08-01 15:50:13 UTC
A few nits here:
- I would replace %setup with %autosetup
- rm -rf egg-info has been deprecated a while ago
- I still would look at distributions not supporting python3; RHEL/CentOS/EPEL does not; adding a tiny %if etc. makes life for those folks easier.

I'll go ahead and apply etc. the patch now. Thanks everyone.


Note You need to log in before you can comment on or make changes to this bug.