Bug 1364123

Summary: Review Request: nodejs-regex-cache - Memoize the results of a call to the RegExp constructor
Product: [Fedora] Fedora Reporter: Jared Smith <jsmith.fedora>
Component: Package ReviewAssignee: Jeroen van Meeuwen <vanmeeuwen+fedora>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: package-review
Target Milestone: ---Flags: vanmeeuwen+fedora: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-08-08 07:52:50 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1364121    
Bug Blocks: 956806, 1387531    

Description Jared Smith 2016-08-04 14:03:51 UTC 
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-regex-cache/nodejs-regex-cache.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-regex-cache/nodejs-regex-cache-0.4.3-2.fc26.src.rpm
Description: Memoize the results of a call to the RegExp constructor
Fedora Account System Username: jsmith
Comment 1 Jeroen van Meeuwen 2016-08-04 14:40:21 UTC 
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-regex-cache/nodejs-regex-cache.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-regex-cache/nodejs-regex-cache-0.4.2-1.fc24.src.rpm
Comment 2 Jeroen van Meeuwen 2016-08-04 14:51:14 UTC 
The tests fail in that a build requires is probably not actually installed.

+ /usr/lib/rpm/nodejs-symlink-deps /usr/lib/node_modules --check
+ /usr/bin/node -e 'require("./")'
+ /usr/bin/mocha -R spec
module.js:442
    throw err;
    ^
Error: Cannot find module 'should'
    at Function.Module._resolveFilename (module.js:440:15)
Comment 3 Jared Smith 2016-08-05 10:09:17 UTC 
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-regex-cache/nodejs-regex-cache.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-regex-cache/nodejs-regex-cache-0.4.3-2.fc26.src.rpm
Comment 4 Gwyn Ciesla 2016-08-07 01:30:11 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-regex-cache
Comment 5 Jared Smith 2016-08-08 07:52:50 UTC 
In rawhide, closing bug