Bug 1364123 - Review Request: nodejs-regex-cache - Memoize the results of a call to the RegExp constructor
Summary: Review Request: nodejs-regex-cache - Memoize the results of a call to the Reg...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jeroen van Meeuwen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1364121
Blocks: nodejs-reviews Node-RED
TreeView+ depends on / blocked
 
Reported: 2016-08-04 14:03 UTC by Jared Smith
Modified: 2016-10-21 08:13 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-08-08 07:52:50 UTC
Type: ---
Embargoed:
vanmeeuwen+fedora: fedora-review+

Attachments (Terms of Use)

Description Jared Smith 2016-08-04 14:03:51 UTC 
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-regex-cache/nodejs-regex-cache.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-regex-cache/nodejs-regex-cache-0.4.3-2.fc26.src.rpm
Description: Memoize the results of a call to the RegExp constructor
Fedora Account System Username: jsmith
Comment 1 Jeroen van Meeuwen 2016-08-04 14:40:21 UTC 
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-regex-cache/nodejs-regex-cache.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-regex-cache/nodejs-regex-cache-0.4.2-1.fc24.src.rpm
Comment 2 Jeroen van Meeuwen 2016-08-04 14:51:14 UTC 
The tests fail in that a build requires is probably not actually installed.

+ /usr/lib/rpm/nodejs-symlink-deps /usr/lib/node_modules --check
+ /usr/bin/node -e 'require("./")'
+ /usr/bin/mocha -R spec
module.js:442
    throw err;
    ^
Error: Cannot find module 'should'
    at Function.Module._resolveFilename (module.js:440:15)
Comment 3 Jared Smith 2016-08-05 10:09:17 UTC 
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-regex-cache/nodejs-regex-cache.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-regex-cache/nodejs-regex-cache-0.4.3-2.fc26.src.rpm
Comment 4 Gwyn Ciesla 2016-08-07 01:30:11 UTC 
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-regex-cache
Comment 5 Jared Smith 2016-08-08 07:52:50 UTC 
In rawhide, closing bug
Note You need to log in before you can comment on or make changes to this bug.