Bug 1364644
| Summary: | Review Request: nodejs-grunt-simple-mocha - A simple wrapper for running tests with Mocha | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jared Smith <jsmith.fedora> |
| Component: | Package Review | Assignee: | Jeroen van Meeuwen <vanmeeuwen+fedora> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review |
| Target Milestone: | --- | Flags: | vanmeeuwen+fedora:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-08-12 17:12:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1364643 | ||
| Bug Blocks: | 956806, 1387531 | ||
|
Description
Jared Smith
2016-08-06 08:07:41 UTC
This one does have rpmlint complain about the wrong interpreter as well. You mentioned the use of /usr/bin/node over /usr/bin/env node was not a packaging guideline yet ratified. I take it this may involve https://fedoraproject.org/wiki/Script_Interpreters_(draft), but the main reasons listed there are not my concern. The RPM dependency side-note is a bigger concern. My main concern is the ability to manipulate what is executed by the user (say, env node=~/bin/node and worse). In any case, rpmlint reports it as an error; nodejs-grunt-simple-mocha.noarch: E: wrong-script-interpreter /usr/lib/node_modules/grunt-simple-mocha/bin/grunt-simple-mocha /usr/bin/env node Fixed. Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-grunt-simple-mocha/nodejs-grunt-simple-mocha.spec SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-grunt-simple-mocha/nodejs-grunt-simple-mocha-0.4.1-3.fc26.src.rpm Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-grunt-simple-mocha In rawhide, closing bug In rawhide, closing bug |