Bug 1364644 - Review Request: nodejs-grunt-simple-mocha - A simple wrapper for running tests with Mocha
Summary: Review Request: nodejs-grunt-simple-mocha - A simple wrapper for running test...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jeroen van Meeuwen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1364643
Blocks: nodejs-reviews Node-RED
TreeView+ depends on / blocked
 
Reported: 2016-08-06 08:07 UTC by Jared Smith
Modified: 2016-10-21 08:13 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-08-12 17:12:31 UTC
Type: ---
Embargoed:
vanmeeuwen+fedora: fedora-review+


Attachments (Terms of Use)

Description Jared Smith 2016-08-06 08:07:41 UTC
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-grunt-simple-mocha/nodejs-grunt-simple-mocha.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-grunt-simple-mocha/nodejs-grunt-simple-mocha-0.4.1-2.fc26.src.rpm
Description: A simple wrapper for running tests with Mocha
Fedora Account System Username: jsmith

Comment 1 Jeroen van Meeuwen 2016-08-07 10:35:56 UTC
This one does have rpmlint complain about the wrong interpreter as well. You mentioned the use of /usr/bin/node over /usr/bin/env node was not a packaging guideline yet ratified.

I take it this may involve https://fedoraproject.org/wiki/Script_Interpreters_(draft), but the main reasons listed there are not my concern. The RPM dependency side-note is a bigger concern. My main concern is the ability to manipulate what is executed by the user (say, env node=~/bin/node and worse).

In any case, rpmlint reports it as an error;

nodejs-grunt-simple-mocha.noarch: E: wrong-script-interpreter /usr/lib/node_modules/grunt-simple-mocha/bin/grunt-simple-mocha /usr/bin/env node

Comment 3 Gwyn Ciesla 2016-08-11 13:40:13 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/nodejs-grunt-simple-mocha

Comment 4 Jared Smith 2016-08-12 17:12:31 UTC
In rawhide, closing bug

Comment 5 Jared Smith 2016-08-12 17:17:45 UTC
In rawhide, closing bug


Note You need to log in before you can comment on or make changes to this bug.