Bug 1364725
| Summary: | Review Request: python-pytest-runner - Invoke py.test as distutils command with dependency resolution | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Vadim Rutkovsky <vrutkovs> |
| Component: | Package Review | Assignee: | Gwyn Ciesla <gwync> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jonathan.underwood, mcepl, mcepl, package-review |
| Target Milestone: | --- | Flags: | gwync:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-08-23 12:48:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1364736, 1366410 | ||
|
Description
Vadim Rutkovsky
2016-08-06 15:35:35 UTC
*** Bug 1341641 has been marked as a duplicate of this bug. *** Hello Vadim, I am a sponsor. Have you done any practice reviews? (In reply to Jon Ciesla from comment #2) > Hello Vadim, I am a sponsor. Have you done any practice reviews? Hi, Yes, I did several: * https://bugzilla.redhat.com/show_bug.cgi?id=1364777#c3 * https://bugzilla.redhat.com/show_bug.cgi?id=1364620#c5 I had one addition, and you should be more verbose, especially with rpmlint warnings (they should be present, even the ignorable warnings, for reference), but they look mostly ok. I'll review this. (In reply to Jon Ciesla from comment #4) > I had one addition, and you should be more verbose, especially with rpmlint > warnings (they should be present, even the ignorable warnings, for > reference), but they look mostly ok. Oh, I see, I though those are for reviewer only so I removed those. Thanks! - rpmlint checks return: python-pytest-runner.src: W: spelling-error Summary(en_US) py -> pt, p, y The value of this tag appears to be misspelled. Please double-check. python-pytest-runner.src: W: spelling-error Summary(en_US) distutils -> distillates The value of this tag appears to be misspelled. Please double-check. python-pytest-runner.src: W: spelling-error %description -l en_US py -> pt, p, y The value of this tag appears to be misspelled. Please double-check. python-pytest-runner.src: E: description-line-too-long C Setup scripts can use pytest-runner to add setup.py test support for pytest runner. Your description lines must not exceed 80 characters. If a line is exceeding this number, cut it to fit in two lines. - package meets naming guidelines - package meets packaging guidelines - license ( MIT ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Looks good, just needs the description shortened, which you can do prior to import. What's your FAS username? APPROVED NM found it. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-pytest-runner python-pytest-runner-2.9-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-7fcf985c95 python-pytest-runner-2.9-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ab60aa64b1 python-pytest-runner-2.9-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-ab60aa64b1 python-pytest-runner-2.9-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7fcf985c95 python-pytest-runner-2.9-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. python-pytest-runner-2.9-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. Any chance of pushing this to F23 as well? I'd like to enable tests in the sshuttle package which requires pytest-runner in the buildroot (In reply to Jonathan Underwood from comment #15) > Any chance of pushing this to F23 as well? I'd like to enable tests in the > sshuttle package which requires pytest-runner in the buildroot You can request branch in PkgDB. But I would prefer to not do this, as you will have to change spec a bit and F23 will be EOL quite soon. |