Bug 1365506

Summary:	gfapi: use const qualifier for glfs_*timens()
Product:	[Community] GlusterFS	Reporter:	Oleksandr Natalenko <oleksandr>
Component:	libgfapi	Assignee:	Oleksandr Natalenko <oleksandr>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Sudhir D <sdharane>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-11-22 13:28:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Oleksandr Natalenko 2016-08-09 12:04:54 UTC

glfs_*timens() functions have the last argument of struct timespec type that is supposed to be const. Now using glfs_*timens() in fops, implemented on top of FUSE library, leads to compiler-time warning about discarding const qualifier.

Introducing const qualifier does not break ABI, so let's just fix it.

Comment 1 Vijay Bellur 2016-08-09 12:07:27 UTC

REVIEW: http://review.gluster.org/15119 (gfapi: use const qualifier for glfs_*timens()) posted (#1) for review on master by Oleksandr Natalenko (oleksandr)

Comment 2 Vijay Bellur 2016-08-10 11:26:51 UTC

COMMIT: http://review.gluster.org/15119 committed in master by Kaleb KEITHLEY (kkeithle) 
------
commit 09b0ebf75ad2eb76002cd1801ce64f644925af45
Author: Oleksandr Natalenko <oleksandr>
Date:   Tue Aug 9 14:58:08 2016 +0300

    gfapi: use const qualifier for glfs_*timens()
    
    glfs_*timens() functions have the last argument
    of struct timespec type that is supposed to be
    const. Now using glfs_*timens() in fops, implemented
    on top of FUSE library, leads to compiler-time warning
    about discarding const qualifier.
    
    Introducing const qualifier does not break ABI,
    so let's just fix it.
    
    Change-Id: Iea2a1018de7dce67f67a8229671a5978246de800
    BUG: 1365506
    Signed-off-by: Oleksandr Natalenko <oleksandr>
    Reviewed-on: http://review.gluster.org/15119
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>
    CentOS-regression: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>