Bug 1365506 - gfapi: use const qualifier for glfs_*timens()
Summary: gfapi: use const qualifier for glfs_*timens()
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: libgfapi
Version: mainline
Hardware: All
OS: All
unspecified
low
Target Milestone: ---
Assignee: Oleksandr Natalenko
QA Contact: Sudhir D
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-09 12:04 UTC by Oleksandr Natalenko
Modified: 2016-11-22 13:28 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-22 13:28:59 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:

Attachments (Terms of Use)

Description Oleksandr Natalenko 2016-08-09 12:04:54 UTC 
glfs_*timens() functions have the last argument of struct timespec type that is supposed to be const. Now using glfs_*timens() in fops, implemented on top of FUSE library, leads to compiler-time warning about discarding const qualifier.

Introducing const qualifier does not break ABI, so let's just fix it.
Comment 1 Vijay Bellur 2016-08-09 12:07:27 UTC 
REVIEW: http://review.gluster.org/15119 (gfapi: use const qualifier for glfs_*timens()) posted (#1) for review on master by Oleksandr Natalenko (oleksandr)
Comment 2 Vijay Bellur 2016-08-10 11:26:51 UTC 
COMMIT: http://review.gluster.org/15119 committed in master by Kaleb KEITHLEY (kkeithle) 
------
commit 09b0ebf75ad2eb76002cd1801ce64f644925af45
Author: Oleksandr Natalenko <oleksandr>
Date:   Tue Aug 9 14:58:08 2016 +0300

    gfapi: use const qualifier for glfs_*timens()
    
    glfs_*timens() functions have the last argument
    of struct timespec type that is supposed to be
    const. Now using glfs_*timens() in fops, implemented
    on top of FUSE library, leads to compiler-time warning
    about discarding const qualifier.
    
    Introducing const qualifier does not break ABI,
    so let's just fix it.
    
    Change-Id: Iea2a1018de7dce67f67a8229671a5978246de800
    BUG: 1365506
    Signed-off-by: Oleksandr Natalenko <oleksandr>
    Reviewed-on: http://review.gluster.org/15119
    Smoke: Gluster Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>
    CentOS-regression: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
Note You need to log in before you can comment on or make changes to this bug.