Bug 1365684

Summary: cannot set custom include roots
Product: [Fedora] Fedora Reporter: evantschuy
Component: python-nssAssignee: John Dennis <jdennis>
Status: CLOSED UPSTREAM QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: rawhideCC: jdennis
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-08-09 21:45:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
a patch containing a fix, adding --include-root=/path/to/include support none

Description evantschuy 2016-08-09 20:44:07 UTC
Created attachment 1189415 [details]
a patch containing a fix, adding --include-root=/path/to/include support

It's impossible to install python-nss if not using the default include paths (in both 1.0beta and 0.16/0.17):(

I ran into this using buildroot to build a custom image with nss. I wanted to be able to specify the path of the include roots as either an env variable, or as a cli arg. Buildroot's gcc will throw if anything it compiles attempts to access a library outside of its root. In order to add python-nss, I had to add buildroot by hand to the include_roots argument to find_include_dir.

With this patch, I can install python-nss on a buildroot image entirely automatically by passing --include-root=/my/buildroot/usr/include.

Comment 1 John Dennis 2016-08-09 21:45:41 UTC
Thank you for the patch Evan. I'm applying it now. You will get credit in the commit message. Not sure when a new release will be pushed but when it is your patch will show up.

Comment 2 evantschuy 2016-08-09 21:54:10 UTC
awesome, good to hear.