Bug 1365684 - cannot set custom include roots
Summary: cannot set custom include roots
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: python-nss
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: John Dennis
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-09 20:44 UTC by evantschuy
Modified: 2016-08-09 21:54 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-08-09 21:45:41 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
a patch containing a fix, adding --include-root=/path/to/include support (1.79 KB, patch)
2016-08-09 20:44 UTC, evantschuy
no flags Details | Diff

Description evantschuy 2016-08-09 20:44:07 UTC
Created attachment 1189415 [details]
a patch containing a fix, adding --include-root=/path/to/include support

It's impossible to install python-nss if not using the default include paths (in both 1.0beta and 0.16/0.17):(

I ran into this using buildroot to build a custom image with nss. I wanted to be able to specify the path of the include roots as either an env variable, or as a cli arg. Buildroot's gcc will throw if anything it compiles attempts to access a library outside of its root. In order to add python-nss, I had to add buildroot by hand to the include_roots argument to find_include_dir.

With this patch, I can install python-nss on a buildroot image entirely automatically by passing --include-root=/my/buildroot/usr/include.

Comment 1 John Dennis 2016-08-09 21:45:41 UTC
Thank you for the patch Evan. I'm applying it now. You will get credit in the commit message. Not sure when a new release will be pushed but when it is your patch will show up.

Comment 2 evantschuy 2016-08-09 21:54:10 UTC
awesome, good to hear.


Note You need to log in before you can comment on or make changes to this bug.