Bug 1365794 (python-keyrings-alt)

Summary:	Review Request: python-keyrings-alt - Alternate keyring implementations for python-keyring
Product:	[Fedora] Fedora	Reporter:	Igor Gnatenko <ignatenko>
Component:	Package Review	Assignee:	Charalampos Stratakis <cstratak>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	bperkins, cstratak, package-review, pviktori
Target Milestone:	---	Flags:	cstratak: fedora-review?
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-02-23 11:52:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1365765

Description Igor Gnatenko 2016-08-10 08:45:41 UTC

Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-keyrings-alt.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/python-keyrings-alt-1.1.1-1.fc26.src.rpm
Description:
Alternate keyring backend implementations for use with the python-keyring
package.
Fedora Account System Username: ignatenkobrain

Comment 1 Charalampos Stratakis 2016-08-11 13:45:49 UTC

Missing some BuildRequires from both subpackages in order to run the tests:

BuildRequires:  python2-setuptools_scm
BuildRequires:  python-keyring
BuildRequires:  python2-mock

BuildRequires:  python3-setuptools_scm
BuildRequires:  python3-keyring
BuildRequires:  python3-mock


README.txt file doesn't exist, it should be README.rst

Correct path for nspkg.pth files should be in the form:

%{python2_sitelib}/%{srcname}-%{version}-py%{python2_version}-nspkg.pth

and

%{python3_sitelib}/%{srcname}-%{version}-py%{python3_version}-nspkg.pth

Comment 2 Charalampos Stratakis 2016-09-14 09:51:36 UTC

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[!]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
Note: https://github.com/jaraco/keyrings.alt/issues/6

Sent a pull request upstream as well to include a license:
https://github.com/jaraco/keyrings.alt/pull/8

Comment 3 Charalampos Stratakis 2016-12-06 15:04:26 UTC

Pull request has been merged and version 1.2 was released which includes the MIT license file, so the review can proceed.

Comment 4 Petr Viktorin (pviktori) 2017-10-31 15:08:24 UTC

What's the status here?

Comment 5 Igor Gnatenko 2018-02-23 11:52:08 UTC

Sorry, don't have time for this.