Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-keyrings-alt.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/python-keyrings-alt-1.1.1-1.fc26.src.rpm Description: Alternate keyring backend implementations for use with the python-keyring package. Fedora Account System Username: ignatenkobrain
Missing some BuildRequires from both subpackages in order to run the tests: BuildRequires: python2-setuptools_scm BuildRequires: python-keyring BuildRequires: python2-mock BuildRequires: python3-setuptools_scm BuildRequires: python3-keyring BuildRequires: python3-mock README.txt file doesn't exist, it should be README.rst Correct path for nspkg.pth files should be in the form: %{python2_sitelib}/%{srcname}-%{version}-py%{python2_version}-nspkg.pth and %{python3_sitelib}/%{srcname}-%{version}-py%{python3_version}-nspkg.pth
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. Note: https://github.com/jaraco/keyrings.alt/issues/6 Sent a pull request upstream as well to include a license: https://github.com/jaraco/keyrings.alt/pull/8
Pull request has been merged and version 1.2 was released which includes the MIT license file, so the review can proceed.
What's the status here?
Sorry, don't have time for this.