Bug 1365869

Summary:	gfapi: use const qualifier for glfs_*timens()
Product:	[Community] GlusterFS	Reporter:	Oleksandr Natalenko <oleksandr>
Component:	libgfapi	Assignee:	Oleksandr Natalenko <oleksandr>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Sudhir D <sdharane>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	3.7.14	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	glusterfs-3.7.15	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-09-01 09:21:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Oleksandr Natalenko 2016-08-10 11:33:29 UTC

Backport https://bugzilla.redhat.com/show_bug.cgi?id=1365506 fix to 3.7.

Comment 1 Vijay Bellur 2016-08-10 11:33:56 UTC

REVIEW: http://review.gluster.org/15137 (gfapi: use const qualifier for glfs_*timens()) posted (#1) for review on release-3.7 by Oleksandr Natalenko (oleksandr)

Comment 2 Vijay Bellur 2016-08-12 11:20:07 UTC

COMMIT: http://review.gluster.org/15137 committed in release-3.7 by Kaleb KEITHLEY (kkeithle) 
------
commit 429d587114f1598774c1d3def064ea4f6415521b
Author: Oleksandr Natalenko <oleksandr>
Date:   Tue Aug 9 14:58:08 2016 +0300

    gfapi: use const qualifier for glfs_*timens()
    
    glfs_*timens() functions have the last argument
    of struct timespec type that is supposed to be
    const. Now using glfs_*timens() in fops, implemented
    on top of FUSE library, leads to compiler-time warning
    about discarding const qualifier.
    
    Introducing const qualifier does not break ABI,
    so let's just fix it.
    
    > Reviewed-on: http://review.gluster.org/15119
    > Smoke: Gluster Build System <jenkins.org>
    > CentOS-regression: Gluster Build System <jenkins.org>
    > NetBSD-regression: NetBSD Build System <jenkins.org>
    > Reviewed-by: Niels de Vos <ndevos>
    
    BUG: 1365869
    Change-Id: Iea2a1018de7dce67f67a8229671a5978246de800
    Signed-off-by: Oleksandr Natalenko <oleksandr>
    Reviewed-on: http://review.gluster.org/15137
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Reviewed-by: Prashanth Pai <ppai>

Comment 3 Kaushal 2016-09-01 09:21:28 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.15, please open a new bug report.

glusterfs-3.7.15 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-devel/2016-September/050714.html
[2] https://www.gluster.org/pipermail/gluster-users/

Comment 4 Kaushal 2016-09-01 09:33:16 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.15, please open a new bug report.

glusterfs-3.7.15 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-devel/2016-September/050714.html
[2] https://www.gluster.org/pipermail/gluster-users/