Bug 1366017
| Summary: | Review Request: aries-blueprint-cm - Apache Aries Blueprint CM | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | gil cattaneo <puntogil> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-08-27 10:30:36 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1347973, 1347977, 1365144 | ||
| Bug Blocks: | 1166658 | ||
|
Description
gil cattaneo
2016-08-10 18:40:35 UTC
Obsoletes: aries-blueprint < %{version}
should be
Obsoletes: aries-blueprint < 1.0.8
[https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages]
+ license is acceptable (ASL-2.0)
+ license is specified correctly
+ latest version
+ builds and installs OK
+ normal maven packaging macros are used
+ no scriptlets necessary
+ rpmlint and fedora-review are happy
+ BR/R/P look OK (except for the small issue above)
Package is APPROVED.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > Obsoletes: aries-blueprint < %{version} > should be > Obsoletes: aries-blueprint < 1.0.8 > [https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming. > 2FReplacing_Existing_Packages] I tried to contact the package maintainer, but I was not lucky. I will have to wait until you return from vacation > + BR/R/P look OK (except for the small issue above) > Package is APPROVED. Thanks for the review! create new SCM requests: https://admin.fedoraproject.org/pkgdb/package/requests/7208 https://admin.fedoraproject.org/pkgdb/package/requests/7209 (In reply to gil cattaneo from comment #2) > (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > > Obsoletes: aries-blueprint < %{version} > > should be > > Obsoletes: aries-blueprint < 1.0.8 > > [https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming. > > 2FReplacing_Existing_Packages] > > I tried to contact the package maintainer, but I was not lucky. I will have > to wait until you return from vacation Hm, I don't understand. aries-blueprint should be retired probably, but this doesn't block this package in any way. But now I see that aries-blueprint uses epoch. So the proper tag might actually be: Obsoletes: aries-blueprint < 1:0.3.2 Please test the upgrade path. Spec URL: https://gil.fedorapeople.org/aries-blueprint-cm.spec SRPM URL: https://gil.fedorapeople.org/aries-blueprint-cm-1.0.8-1.fc24.src.rpm Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/aries-blueprint-cm aries-blueprint-cm-1.0.8-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e0d2ae5e36 aries-blueprint-cm-1.0.8-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e0d2ae5e36 aries-blueprint-cm-1.0.8-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |