Bug 1366017 - Review Request: aries-blueprint-cm - Apache Aries Blueprint CM
Summary: Review Request: aries-blueprint-cm - Apache Aries Blueprint CM
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1347973 1347977 1365144
Blocks: 1166658
TreeView+ depends on / blocked
 
Reported: 2016-08-10 18:40 UTC by gil cattaneo
Modified: 2016-08-27 10:30 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-08-27 10:30:36 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+


Attachments (Terms of Use)

Description gil cattaneo 2016-08-10 18:40:35 UTC
Spec URL: https://gil.fedorapeople.org/aries-blueprint-cm.spec
SRPM URL: https://gil.fedorapeople.org/aries-blueprint-cm-1.0.8-1.fc24.src.rpm
Description: This bundle contains the ConfigAdmin namespace for blueprint.
Fedora Account System Username: gil

Comment 1 Zbigniew Jędrzejewski-Szmek 2016-08-12 13:43:37 UTC
Obsoletes:     aries-blueprint < %{version}
should be
Obsoletes:     aries-blueprint < 1.0.8
[https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages]

+ license is acceptable (ASL-2.0)
+ license is specified correctly
+ latest version
+ builds and installs OK
+ normal maven packaging macros are used
+ no scriptlets necessary
+ rpmlint and fedora-review are happy
+ BR/R/P look OK (except for the small issue above)

Package is APPROVED.

Comment 2 gil cattaneo 2016-08-12 14:10:32 UTC
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> Obsoletes:     aries-blueprint < %{version}
> should be
> Obsoletes:     aries-blueprint < 1.0.8
> [https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.
> 2FReplacing_Existing_Packages]

I tried to contact the package maintainer, but I was not lucky. I will have to wait until you return from vacation

> + BR/R/P look OK (except for the small issue above)

> Package is APPROVED.

Thanks for the review!

create new SCM requests:
https://admin.fedoraproject.org/pkgdb/package/requests/7208
https://admin.fedoraproject.org/pkgdb/package/requests/7209

Comment 3 Zbigniew Jędrzejewski-Szmek 2016-08-12 14:15:25 UTC
(In reply to gil cattaneo from comment #2)
> (In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> > Obsoletes:     aries-blueprint < %{version}
> > should be
> > Obsoletes:     aries-blueprint < 1.0.8
> > [https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.
> > 2FReplacing_Existing_Packages]
> 
> I tried to contact the package maintainer, but I was not lucky. I will have
> to wait until you return from vacation

Hm, I don't understand. aries-blueprint should be retired probably, but this doesn't block this package in any way.

But now I see that aries-blueprint uses epoch. So the proper tag might actually be:
Obsoletes: aries-blueprint < 1:0.3.2

Please test the upgrade path.

Comment 5 Gwyn Ciesla 2016-08-15 14:21:51 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/aries-blueprint-cm

Comment 6 Fedora Update System 2016-08-15 20:57:50 UTC
aries-blueprint-cm-1.0.8-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-e0d2ae5e36

Comment 7 Fedora Update System 2016-08-16 16:26:05 UTC
aries-blueprint-cm-1.0.8-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-e0d2ae5e36

Comment 8 Fedora Update System 2016-08-27 10:30:34 UTC
aries-blueprint-cm-1.0.8-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.