Bug 1366277
| Summary: | python-gfm - Github-Flavored Markdown for Python-Markdown | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Germano Massullo (Thetra) <germano.massullo> |
| Component: | Package Review | Assignee: | Zbigniew Jędrzejewski-Szmek <zbyszek> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | zbyszek:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | Dependency of https://github.com/digitalocean/netbox | ||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-08-27 10:19:15 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Germano Massullo (Thetra)
2016-08-11 13:32:42 UTC
I'd suggest:
%global _description \
This is an implementation of GitHub-Flavored Markdown written as an extension \
...
%description %_description
%description -n python2-%{pypi_name} %_description
...
I'm not sure about the name: python-py-* suggests that this has something to do with py.test and python-py. Maybe the name should just be python-gfm? This matches the module name too.
? package name is OK
+ license is acceptable (BSD 3-clause)
+ license is specified correctly
+ latest version is packaged
+ modern python packaging template is used
+ %python_provide macro is used
+ P/R/BR look correct
+ no scriptlets necessary
+ %check is present
+ builds and installs OK
+ fedora-review and rpmlint are happy
rpmlint:
python-py-gfm.src: E: description-line-too-long C to the Python Markdown library. It aims for maximal compatibility with GitHub's rendering.
OK, looks good, only thing is the name, maybe.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > I'm not sure about the name: python-py-* suggests that this has something to > do with py.test and python-py. Maybe the name should just be python-gfm? > This matches the module name too. even netbox names it with "py" prefix https://github.com/digitalocean/netbox/blob/develop/requirements.txt#L15 Perhaps we should ask to py-gfm upstream developers? (In reply to Germano Massullo from comment #2) > even netbox names it with "py" prefix > https://github.com/digitalocean/netbox/blob/develop/requirements.txt#L15 I don't think that matters. The names in requirements.txt is completely independent of the Fedora package name. We add python- prefix anyway. https://germano.fedorapeople.org/package_reviews/python-gfm/python-gfm.spec https://germano.fedorapeople.org/package_reviews/python-gfm/python-gfm-0.1.3-1.fc24.src.rpm I have also edited the paths. You may want to check them again. rpmbuild -ba worked fine # to do: check if py-gfm BSD style license is compliant to BSD license → it is, you can remove this comment Package is APPROVED. rpmlint: python2-gfm.noarch: E: description-line-too-long C to the Python Markdown library. It aims for maximal compatibility with GitHub's rendering. Please wrap to 80 columns ;) Files updated as requested https://germano.fedorapeople.org/package_reviews/python-gfm/python-gfm.spec https://germano.fedorapeople.org/package_reviews/python-gfm/python-gfm-0.1.3-1.fc24.src.rpm Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-gfm python-gfm-0.1.3-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-336acf2def python-gfm-0.1.3-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d68bd1607d python-gfm-0.1.3-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-84dce5e362 python-gfm-0.1.3-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6afe4007a6 python-gfm-0.1.3-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6afe4007a6 python-gfm-0.1.3-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-84dce5e362 python-gfm-0.1.3-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-336acf2def python-gfm-0.1.3-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d68bd1607d python-gfm-0.1.3-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. python-gfm-0.1.3-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. python-gfm-0.1.3-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. python-gfm-0.1.3-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. |