Bug 1366277 - python-gfm - Github-Flavored Markdown for Python-Markdown
Summary: python-gfm - Github-Flavored Markdown for Python-Markdown
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: Dependency of https://github.com/digi...
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-11 13:32 UTC by Germano Massullo
Modified: 2016-09-05 01:47 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-08-27 10:19:15 UTC
Type: Bug
Embargoed:
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Germano Massullo 2016-08-11 13:32:42 UTC
spec file: https://germano.fedorapeople.org/package_reviews/python-py-gfm/python-py-gfm.spec
srpm file: https://germano.fedorapeople.org/package_reviews/python-py-gfm/python-py-gfm-0.1.3-1.fc24.src.rpm
FAS name: germano

message to the package reviewer: I have a dubt about the BSD license, because the license is BSD style. More details in the spec file comments

Comment 1 Zbigniew Jędrzejewski-Szmek 2016-08-11 23:18:45 UTC
I'd suggest:
%global _description \
This is an implementation of GitHub-Flavored Markdown written as an extension \
...

%description %_description
%description -n python2-%{pypi_name} %_description
...


I'm not sure about the name: python-py-* suggests that this has something to do with py.test and python-py. Maybe the name should just be python-gfm? This matches the module name too.

? package name is OK
+ license is acceptable (BSD 3-clause)
+ license is specified correctly
+ latest version is packaged
+ modern python packaging template is used
+ %python_provide macro is used
+ P/R/BR look correct
+ no scriptlets necessary
+ %check is present
+ builds and installs OK
+ fedora-review and rpmlint are happy

rpmlint:
python-py-gfm.src: E: description-line-too-long C to the Python Markdown library. It aims for maximal compatibility with GitHub's rendering.

OK, looks good, only thing is the name, maybe.

Comment 2 Germano Massullo 2016-08-11 23:58:34 UTC
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)
> I'm not sure about the name: python-py-* suggests that this has something to
> do with py.test and python-py. Maybe the name should just be python-gfm?
> This matches the module name too.

even netbox names it with "py" prefix
https://github.com/digitalocean/netbox/blob/develop/requirements.txt#L15
Perhaps we should ask to py-gfm upstream developers?

Comment 3 Zbigniew Jędrzejewski-Szmek 2016-08-12 00:00:54 UTC
(In reply to Germano Massullo from comment #2)
> even netbox names it with "py" prefix
> https://github.com/digitalocean/netbox/blob/develop/requirements.txt#L15
I don't think that matters. The names in requirements.txt is completely independent of the Fedora package name. We add python- prefix anyway.

Comment 5 Germano Massullo 2016-08-12 08:41:05 UTC
I have also edited the paths. You may want to check them again.
rpmbuild -ba worked fine

Comment 6 Zbigniew Jędrzejewski-Szmek 2016-08-12 14:05:23 UTC
# to do: check if py-gfm BSD style license is compliant to BSD license
→ it is, you can remove this comment

Package is APPROVED.

Comment 7 Zbigniew Jędrzejewski-Szmek 2016-08-12 14:06:37 UTC
rpmlint:
python2-gfm.noarch: E: description-line-too-long C to the Python Markdown library. It aims for maximal compatibility with GitHub's rendering.

Please wrap to 80 columns ;)

Comment 9 Gwyn Ciesla 2016-08-15 14:52:30 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-gfm

Comment 10 Fedora Update System 2016-08-19 18:49:43 UTC
python-gfm-0.1.3-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-336acf2def

Comment 11 Fedora Update System 2016-08-19 18:49:50 UTC
python-gfm-0.1.3-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d68bd1607d

Comment 12 Fedora Update System 2016-08-19 18:49:54 UTC
python-gfm-0.1.3-2.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-84dce5e362

Comment 13 Fedora Update System 2016-08-19 18:49:58 UTC
python-gfm-0.1.3-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6afe4007a6

Comment 14 Fedora Update System 2016-08-20 18:50:20 UTC
python-gfm-0.1.3-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-6afe4007a6

Comment 15 Fedora Update System 2016-08-21 03:46:48 UTC
python-gfm-0.1.3-2.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-84dce5e362

Comment 16 Fedora Update System 2016-08-21 04:22:28 UTC
python-gfm-0.1.3-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-336acf2def

Comment 17 Fedora Update System 2016-08-21 04:24:31 UTC
python-gfm-0.1.3-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d68bd1607d

Comment 18 Fedora Update System 2016-08-27 10:19:13 UTC
python-gfm-0.1.3-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 19 Fedora Update System 2016-08-29 18:53:43 UTC
python-gfm-0.1.3-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 20 Fedora Update System 2016-08-29 21:21:42 UTC
python-gfm-0.1.3-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 21 Fedora Update System 2016-09-05 01:47:04 UTC
python-gfm-0.1.3-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.