Bug 1371163

Summary:	double click stops on ":" char with 0.6.90-1.fc24
Product:	[Fedora] Fedora	Reporter:	Jan Hutař <jhutar>
Component:	xfce4-terminal	Assignee:	Kevin Fenzi <kevin>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	24	CC:	christoph.wickert, jan.kratochvil, kevin, nonamedotc
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://bugzilla.xfce.org/show_bug.cgi?id=12797
Whiteboard:
Fixed In Version:	xfce4-terminal-0.6.92-1.fc25 xfce4-terminal-0.6.92-1.fc24	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-09-11 23:45:57 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jan Hutař 2016-08-29 12:47:29 UTC

Description of problem:
When selecting text by double click, it stops on ":" char with 0.6.90-1.fc24


Version-Release number of selected component (if applicable):
xfce4-terminal-0.6.90-1.fc24.x86_64
It works in xfce4-terminal-0.6.3-9.fc24.x86_64


How reproducible:
always


Steps to Reproduce:
1. # echo "http://example.com"
2. Double click on "example"


Actual results:
"example.com" is selected


Expected results:
"http://example.com" should be selected

Comment 1 Kevin Fenzi 2016-08-29 15:30:16 UTC

Would you be willing to file this upstream at bugzilla.xfce.org ? 

Or would you like me to do so?

Comment 2 Jan Hutař 2016-08-30 10:04:03 UTC

You are right. Reported as:

https://bugzilla.xfce.org/show_bug.cgi?id=12797

Comment 3 Jan Hutař 2016-09-01 05:05:14 UTC

From upstream BZ:

(In reply to Igor from comment #3)
> 0.6.91 has been released:
> http://archive.xfce.org/src/apps/xfce4-terminal/0.6/xfce4-terminal-0.6.91.
> tar.bz2
> It contains the fix.

Comment 4 Jan Kratochvil 2016-09-01 07:59:08 UTC

I also see double-click selection broken in F-24 XFCE but I am not sure it is the same bug.  Could be this Bug backported first?
/var/log/messages:
/usr/libexec/gdm-x-session: (xfce4-terminal:3479): Vte-WARNING **: (vtegtk.cc:1739):int vte_terminal_match_add_gregex(VteTerminal*, GRegex*, GRegexMatchFlags): runtime check failed: (g_regex_get_compile_flags(gregex) & G_REGEX_MULTILINE)

Comment 5 Kevin Fenzi 2016-09-01 20:28:04 UTC

(In reply to Jan Kratochvil from comment #4)
> I also see double-click selection broken in F-24 XFCE but I am not sure it
> is the same bug.  

I think it is. However I am seeing some other issues with 0.6.91, so I don't want to push that until they are sorted out. 

> Could be this Bug backported first?
> /var/log/messages:
> /usr/libexec/gdm-x-session: (xfce4-terminal:3479): Vte-WARNING **:
> (vtegtk.cc:1739):int vte_terminal_match_add_gregex(VteTerminal*, GRegex*,
> GRegexMatchFlags): runtime check failed: (g_regex_get_compile_flags(gregex)
> & G_REGEX_MULTILINE)

Can you report that one upstream?

Comment 6 Jan Kratochvil 2016-09-01 20:48:03 UTC

(In reply to Kevin Fenzi from comment #5)
> Can you report that one upstream?

Filed: https://bugzilla.gnome.org/show_bug.cgi?id=770718

Comment 7 Kevin Fenzi 2016-09-01 20:52:45 UTC

I meant bugzilla.xfce.org... unless you think this is a vte291 bug somehow?

Comment 8 Jan Kratochvil 2016-09-01 21:04:21 UTC

Filed: https://bugzilla.xfce.org/show_bug.cgi?id=12812

Comment 9 Kevin Fenzi 2016-09-02 21:18:55 UTC

Can you test this scratch build of 0.6.91 and see if: 

a) it solves this bug

and 

b) if there's any oddities you see in window sizes or --geometry WxH

https://koji.fedoraproject.org/koji/taskinfo?taskID=15473669

Comment 10 Jan Kratochvil 2016-09-02 21:31:23 UTC

(In reply to Kevin Fenzi from comment #9)
> a) it solves this bug

Yes, it fixed the double-click selection, thanks.

> b) if there's any oddities you see in window sizes or --geometry WxH

I do not see anything but I haven't really tested this one. I could reboot the host to see whether all the windows restore correctly but I do not like doing all the system state recovery after a reboot, ping me if you really need that.

Comment 11 Fedora Update System 2016-09-06 16:52:59 UTC

xfce4-terminal-0.6.92-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-4aa10d8b9f

Comment 12 Fedora Update System 2016-09-06 16:53:25 UTC

xfce4-terminal-0.6.92-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-5afa98f345

Comment 13 Fedora Update System 2016-09-07 03:20:44 UTC

xfce4-terminal-0.6.92-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-4aa10d8b9f

Comment 14 Fedora Update System 2016-09-09 19:21:41 UTC

xfce4-terminal-0.6.92-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-5afa98f345

Comment 15 Fedora Update System 2016-09-11 23:45:52 UTC

xfce4-terminal-0.6.92-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

Comment 16 Fedora Update System 2016-09-12 18:50:59 UTC

xfce4-terminal-0.6.92-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.