Bug 1372429
| Summary: | Review Request: openjdk-orb - A downstream fork of OpenJDK's ORB implementation | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | gil cattaneo <puntogil> |
| Component: | Package Review | Assignee: | Jason Taylor <jtfas90> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | jtfas90, package-review |
| Target Milestone: | --- | Flags: | jtfas90:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-09-09 21:48:40 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1181081 | ||
|
Description
gil cattaneo
2016-09-01 17:00:00 UTC
Hi gil, looks like Source0 could be updated to https://github.com/jboss/%{name}/archive/%{name}-%{namedversion}.tar.gz I don't see a line installing the pom.xml. According to https://fedorahosted.org/released/javapackages/doc/ it looks like there should be a: %mvn_artifact pom.xml (In reply to Jason Taylor from comment #2) > I don't see a line installing the pom.xml. According to > https://fedorahosted.org/released/javapackages/doc/ it looks like there > should be a: > > %mvn_artifact pom.xml This should be done only when is used an ant build style all artifacts (pom and jar) are installed with %mvn_install https://fedorahosted.org/released/javapackages/doc/#ant https://fedorahosted.org/released/javapackages/doc/#maven the guideline is not update, now, "%dir %{_javadir}/%{name}" is useless because is already owned (In reply to Jason Taylor from comment #1) > Hi gil, > > looks like Source0 could be updated to > > https://github.com/jboss/%{name}/archive/%{name}-%{namedversion}.tar.gz for me is useless. it should be at the discretion of the packager Looks good then, I see you opened a couple of tickets with upstream regarding the misc licensing fixes. Must and Should components appear to be satisfied. Package approved. (In reply to Jason Taylor from comment #5) > Looks good then, I see you opened a couple of tickets with upstream > regarding the misc licensing fixes. > > Must and Should components appear to be satisfied. Package approved. Thanks! Please, set Status field as ASSIGNED Thanks for the review! create new SCM request/s: https://admin.fedoraproject.org/pkgdb/package/requests/7647 https://admin.fedoraproject.org/pkgdb/package/requests/7648 Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/openjdk-orb openjdk-orb-8.0.7-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-cf92a4ceb2 openjdk-orb-8.0.7-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-cf92a4ceb2 openjdk-orb-8.0.7-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |