Spec URL: https://gil.fedorapeople.org/openjdk-orb.spec SRPM URL: https://gil.fedorapeople.org/openjdk-orb-8.0.7-1.fc24.src.rpm Description: JBoss repackaging of the OpenJDK ORB. Fedora Account System Username: gil Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15464009 Wildfly 10+ dependency
Hi gil, looks like Source0 could be updated to https://github.com/jboss/%{name}/archive/%{name}-%{namedversion}.tar.gz
I don't see a line installing the pom.xml. According to https://fedorahosted.org/released/javapackages/doc/ it looks like there should be a: %mvn_artifact pom.xml
(In reply to Jason Taylor from comment #2) > I don't see a line installing the pom.xml. According to > https://fedorahosted.org/released/javapackages/doc/ it looks like there > should be a: > > %mvn_artifact pom.xml This should be done only when is used an ant build style all artifacts (pom and jar) are installed with %mvn_install https://fedorahosted.org/released/javapackages/doc/#ant https://fedorahosted.org/released/javapackages/doc/#maven the guideline is not update, now, "%dir %{_javadir}/%{name}" is useless because is already owned
(In reply to Jason Taylor from comment #1) > Hi gil, > > looks like Source0 could be updated to > > https://github.com/jboss/%{name}/archive/%{name}-%{namedversion}.tar.gz for me is useless. it should be at the discretion of the packager
Looks good then, I see you opened a couple of tickets with upstream regarding the misc licensing fixes. Must and Should components appear to be satisfied. Package approved.
(In reply to Jason Taylor from comment #5) > Looks good then, I see you opened a couple of tickets with upstream > regarding the misc licensing fixes. > > Must and Should components appear to be satisfied. Package approved. Thanks! Please, set Status field as ASSIGNED
Thanks for the review! create new SCM request/s: https://admin.fedoraproject.org/pkgdb/package/requests/7647 https://admin.fedoraproject.org/pkgdb/package/requests/7648
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/openjdk-orb
openjdk-orb-8.0.7-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-cf92a4ceb2
openjdk-orb-8.0.7-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-cf92a4ceb2
openjdk-orb-8.0.7-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.