Bug 1372768
| Summary: | UX: Error message too vague when creating new automate domain / namespace / object | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Satoe Imaishi <simaishi> | ||||
| Component: | Automate | Assignee: | mkanoor | ||||
| Status: | CLOSED ERRATA | QA Contact: | Matouš Mojžíš <mmojzis> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 5.6.0 | CC: | hkataria, jhardy, mfalesni, mkanoor, mpovolny, obarenbo, simaishi, tfitzger | ||||
| Target Milestone: | GA | Keywords: | ZStream | ||||
| Target Release: | 5.6.3 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | ui:ux:automate:flash_msg | ||||||
| Fixed In Version: | 5.6.3.0 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | 1347158 | Environment: | |||||
| Last Closed: | 2016-11-30 19:53:23 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | CFME Core | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 1347158 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Comment 2
Satoe Imaishi
2016-09-02 15:32:21 UTC
Error message is "Name only alpha numeric and _ . - $ characters are allowed". I think it's really weird and it should be rather something like this: "Only alpha numeric and _ . - $ characters are allowed in the name field". Created attachment 1204209 [details]
flash msg
Can you try this with the latest build the messages have been changed on Sept 12
Fix automate model validation strings
This changes the validation messages from:
"Name only alpha numeric and _ . - characters are allowed"
to
"Name may contain only alphanumeric and _ . - characters"
https://github.com/ManageIQ/manageiq/pull/10982
Hello Madhu, the PR says darga/no, that might be the case? New commit detected on ManageIQ/manageiq/darga: https://github.com/ManageIQ/manageiq/commit/da4afe88ed6f2c66f8e9487fbd521dc948fc1185 commit da4afe88ed6f2c66f8e9487fbd521dc948fc1185 Author: Harpreet Kataria <hkataria> AuthorDate: Mon Sep 12 09:19:17 2016 -0400 Commit: Oleg Barenboim <chessbyte> CommitDate: Fri Oct 7 15:39:48 2016 -0400 Merge pull request #10982 from mzazrivec/fix_flash_errors_in_automate Fix validation flash errors in automate (cherry picked from commit 3d9ddefd5909d6a6909ff7985699a0286d8d2a2d) https://bugzilla.redhat.com/show_bug.cgi?id=1372768 app/controllers/miq_ae_class_controller.rb | 5 ----- lib/miq_automation_engine/models/miq_ae_class.rb | 2 +- lib/miq_automation_engine/models/miq_ae_field.rb | 2 +- lib/miq_automation_engine/models/miq_ae_instance.rb | 2 +- lib/miq_automation_engine/models/miq_ae_method.rb | 2 +- lib/miq_automation_engine/models/miq_ae_namespace.rb | 2 +- 6 files changed, 5 insertions(+), 10 deletions(-) Hi, Could you please try this again. Thanks, Madhu Hi, I tried on 5.6.2.2 and it's not there yet. I also tried it on 5.7.0.6 and there is flash msg as it should be. Satoe, Should that have been included in 5.6.2.2? The code was merged into Darga on October 7th. Thanks, Madhu Verified in 5.6.3.0. Correct error message appeared after filling in wrong domain name. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2016-2839.html |