Bug 1372768 - UX: Error message too vague when creating new automate domain / namespace / object
Summary: UX: Error message too vague when creating new automate domain / namespace / o...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Automate
Version: 5.6.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.6.3
Assignee: mkanoor
QA Contact: Matouš Mojžíš
URL:
Whiteboard: ui:ux:automate:flash_msg
Depends On: 1347158
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-02 15:32 UTC by Satoe Imaishi
Modified: 2022-07-09 07:58 UTC (History)
8 users (show)

Fixed In Version: 5.6.3.0
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1347158
Environment:
Last Closed: 2016-11-30 19:53:23 UTC
Category: ---
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
flash msg (59.00 KB, image/png)
2016-09-23 15:06 UTC, Matouš Mojžíš
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2016:2839 0 normal SHIPPED_LIVE Important: CFME 5.6.3 security, bug fix, and enhancement update 2016-12-01 00:51:49 UTC

Comment 2 Satoe Imaishi 2016-09-02 15:32:21 UTC
This was fixed in 5.6.1. Please move to CLOSED CURRENTRELEASE if verification passes.

Comment 3 Matouš Mojžíš 2016-09-23 15:06:18 UTC
Error message is "Name only alpha numeric and _ . - $ characters are allowed".
I think it's really weird and it should be rather something like this:
"Only alpha numeric and _ . - $ characters are allowed in the name field".

Comment 4 Matouš Mojžíš 2016-09-23 15:06:41 UTC
Created attachment 1204209 [details]
flash msg

Comment 5 mkanoor 2016-09-26 19:04:45 UTC
Can you try this with the latest build the messages have been changed on Sept 12

Fix automate model validation strings
    
    This changes the validation messages from:
    
        "Name only alpha numeric and _ . - characters are allowed"
    
    to
    
        "Name may contain only alphanumeric and _ . - characters"

https://github.com/ManageIQ/manageiq/pull/10982

Comment 6 Milan Falešník 2016-09-29 14:16:41 UTC
Hello Madhu,

the PR says darga/no, that might be the case?

Comment 7 CFME Bot 2016-10-07 19:41:14 UTC
New commit detected on ManageIQ/manageiq/darga:
https://github.com/ManageIQ/manageiq/commit/da4afe88ed6f2c66f8e9487fbd521dc948fc1185

commit da4afe88ed6f2c66f8e9487fbd521dc948fc1185
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon Sep 12 09:19:17 2016 -0400
Commit:     Oleg Barenboim <chessbyte>
CommitDate: Fri Oct 7 15:39:48 2016 -0400

    Merge pull request #10982 from mzazrivec/fix_flash_errors_in_automate
    
    Fix validation flash errors in automate
    (cherry picked from commit 3d9ddefd5909d6a6909ff7985699a0286d8d2a2d)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1372768

 app/controllers/miq_ae_class_controller.rb           | 5 -----
 lib/miq_automation_engine/models/miq_ae_class.rb     | 2 +-
 lib/miq_automation_engine/models/miq_ae_field.rb     | 2 +-
 lib/miq_automation_engine/models/miq_ae_instance.rb  | 2 +-
 lib/miq_automation_engine/models/miq_ae_method.rb    | 2 +-
 lib/miq_automation_engine/models/miq_ae_namespace.rb | 2 +-
 6 files changed, 5 insertions(+), 10 deletions(-)

Comment 8 mkanoor 2016-10-17 18:27:04 UTC
Hi,
Could you please try this again.
Thanks,
Madhu

Comment 9 Matouš Mojžíš 2016-10-20 11:34:28 UTC
Hi,
I tried on 5.6.2.2 and it's not there yet.
I also tried it on 5.7.0.6 and there is flash msg as it should be.

Comment 10 mkanoor 2016-10-20 16:27:02 UTC
Satoe,
Should that have been included in 5.6.2.2?
The code was merged into Darga on October 7th.
Thanks,
Madhu

Comment 12 Matouš Mojžíš 2016-11-14 15:37:36 UTC
Verified in 5.6.3.0. Correct error message appeared after filling in wrong domain name.

Comment 14 errata-xmlrpc 2016-11-30 19:53:23 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2839.html


Note You need to log in before you can comment on or make changes to this bug.