Bug 1373004
| Summary: | Review Request: rubygem-tzinfo-data - Timezone Data for TZInfo | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Yanis Guenane <yguenane> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mrunge, package-review, rmeggins, vondruch |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-02-05 11:18:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1460625 | ||
|
Description
Yanis Guenane
2016-09-04 17:55:17 UTC
I don't think we need this library on Fedora, since rubygem-tzinfo (as the only possible user of this package to my knowledge) is using system tzdata. This package was initially created in order to be able to build fluentd[1], which has it as a dependency. Per your command and after looking at the TZInfo documentation, > TZInfo requires a source of timezone data. There are two built-in options: > > The separate TZInfo::Data library (the tzinfo-data gem). TZInfo::Data contains a set of Ruby modules that are generated from the IANA Time Zone Database. > A zoneinfo directory. Most Unix-like systems include a zoneinfo directory containing timezone definitions. These are also generated from the IANA Time Zone Database. > > By default, TZInfo::Data will be used. If TZInfo::Data is not available, then TZInfo will search for a zoneinfo directory instead. So I will hold-on this one and see if I can proceed further without the need of this one. Thank you for pointing it out. [1] https://rubygems.org/gems/fluentd/versions/0.12.5 Bump to 1.2017.3 Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/sbonazzo/ovirt-fluentd/rubygem-tzinfo-data.git/plain/rubygem-tzinfo-data.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/sbonazzo/ovirt-fluentd/fedora-rawhide-x86_64/00678783-rubygem-tzinfo-data/rubygem-tzinfo-data-1.2017.3-1.fc28.src.rpm Matthias can you please review? Also pushed to https://review.rdoproject.org/r/#/c/10682/ For requirements discussion, see https://github.com/fluent/fluentd/issues/1761 I still suggest drop the dependency in fluentd.spec. You can use something like: ~~~ %gemspec_remove_dep -g tzinfo-data "~> 1.0" ~~~ closing this. |