Bug 1373004 - Review Request: rubygem-tzinfo-data - Timezone Data for TZInfo
Summary: Review Request: rubygem-tzinfo-data - Timezone Data for TZInfo
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: oVirt_on_Fedora
TreeView+ depends on / blocked
 
Reported: 2016-09-04 17:55 UTC by Yanis Guenane
Modified: 2018-02-05 11:18 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-02-05 11:18:41 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
RDO 10682 0 None None None 2017-11-23 14:46:03 UTC

Comment 1 Vít Ondruch 2016-09-08 12:21:31 UTC
I don't think we need this library on Fedora, since rubygem-tzinfo (as the only possible user of this package to my knowledge) is using system tzdata.

Comment 2 Yanis Guenane 2016-09-19 08:07:22 UTC
This package was initially created in order to be able to build fluentd[1], which has it as a dependency.

Per your command and after looking at the TZInfo documentation,

> TZInfo requires a source of timezone data. There are two built-in options:
>
>    The separate TZInfo::Data library (the tzinfo-data gem). TZInfo::Data contains a set of Ruby modules that are generated from the IANA Time Zone Database.
>    A zoneinfo directory. Most Unix-like systems include a zoneinfo directory containing timezone definitions. These are also generated from the IANA Time Zone Database.
>
> By default, TZInfo::Data will be used. If TZInfo::Data is not available, then TZInfo will search for a zoneinfo directory instead. 

So I will hold-on this one and see if I can proceed further without the need of this one. Thank you for pointing it out.

[1] https://rubygems.org/gems/fluentd/versions/0.12.5

Comment 4 Matthias Runge 2017-11-23 15:15:02 UTC
For requirements discussion, see 
https://github.com/fluent/fluentd/issues/1761

Comment 5 Vít Ondruch 2017-11-24 10:59:09 UTC
I still suggest drop the dependency in fluentd.spec. You can use something like:

~~~
%gemspec_remove_dep -g tzinfo-data "~> 1.0"
~~~

Comment 6 Matthias Runge 2018-02-05 11:18:41 UTC
closing this.


Note You need to log in before you can comment on or make changes to this bug.