Bug 1373007
| Summary: | Review Request: rubygem-cool.io - A cool framework for doing high performance I/O in Ruby | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Yanis Guenane <yguenane> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | didi, mrunge, package-review, sbonazzo, yguenane, zebob.m |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-04-04 00:45:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Yanis Guenane
2016-09-04 18:07:02 UTC
Can you please bump to latest version? rebase on upstream 1.5.3 Spec URL: http://copr-dist-git.fedorainfracloud.org/cgit/sbonazzo/ovirt-fluentd/rubygem-cool.io.git/plain/rubygem-cool.io.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/sbonazzo/ovirt-fluentd/fedora-rawhide-x86_64/00678787-rubygem-cool.io/rubygem-cool.io-1.5.3-1.fc28.src.rpm Also pushed to https://review.rdoproject.org/r/#/c/10683/ Matthias, can you please review? this package bundles libev. Current fedora even has the same libev version. Please adjust the package to use the system provided version. Rich, any chance you can help with comment #3? I tried hacking the spec file like this and building on fedora 27:
BuildRequires: rubygem-rspec >= 3.5.0
+BuildRequires: libev-devel
Provides: rubygem(%{gem_name}) = %{version}
...
%setup -q -D -T -n %{gem_name}-%{version}
-gem spec %{SOURCE0} -l --ruby > %{gem_name}.gemspec
+# remove libev source files from disk and gemspec
+rm -rf ext/libev
+gem spec %{SOURCE0} -l --ruby | sed 's@"ext/libev/.*".freeze, @@g' > %{gem_name}.gemspec
%build
but this fails to build:
gcc -I. -I/usr/include -I/usr/include/ruby/backward -I/usr/include -I. -DRUBY_VERSION_CODE=242 -DHAVE_SYS_SELECT_H -DEV_USE_SELECT -DHAVE_POLL_H -DEV_USE_POLL -DHAVE_SYS_EPOLL_H -DEV_USE_EPOLL -DHAVE_SYS_RESOURCE_H -DHAVE_LINUX_PROCFS -fPIC -O2 -g -fno-strict-aliasing -m64 -o cool.io_ext.o -c cool.io_ext.c
In file included from cool.io_ext.c:10:0:
ev_wrap.h:9:10: fatal error: ../libev/ev.h: No such file or directory
#include "../libev/ev.h"
^~~~~~~~~~~~~~~
compilation terminated.
The next step would be to do some source code hacking to make it
#include "libev/ev.h"
instead.
In short, it looks like this is going to be a good bit of work . . .
Anyone willing to continue on this? (In reply to Sandro Bonazzola from comment #6) > Anyone willing to continue on this? You should close as DeadReview and open a new bug for your SPEC. CC me for Review. This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience. This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. |