Bug 1373007 - Review Request: rubygem-cool.io - A cool framework for doing high performance I/O in Ruby
Summary: Review Request: rubygem-cool.io - A cool framework for doing high performance...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-DEADREVIEW
TreeView+ depends on / blocked
 
Reported: 2016-09-04 18:07 UTC by Yanis Guenane
Modified: 2021-04-04 00:45 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-04-04 00:45:23 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
RDO 7085 0 None None None 2017-06-15 13:18:05 UTC
RDO 10683 0 None None None 2017-11-23 15:18:49 UTC
Red Hat Bugzilla 1426110 0 medium CLOSED [RFE] Provide fluentd package on Fedora 2022-02-25 08:32:37 UTC

Internal Links: 1426110

Description Yanis Guenane 2016-09-04 18:07:02 UTC
Spec URL: https://gist.githubusercontent.com/Spredzy/a550ce7e1c1fe7ee5c67c350f30d5960/raw/4087cb416cf1e10f5f1b24af4c0a6275f5a691da/rubygem-cool.io.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/9305/15499305/rubygem-cool.io-1.2.4-2.fc24.src.rpm
Description: A cool framework for doing high performance I/O in Ruby
Fedora Account System Username: spredzy

Comment 1 Sandro Bonazzola 2017-02-24 10:00:35 UTC
Can you please bump to latest version?

Comment 3 Matthias Runge 2017-12-04 13:05:37 UTC
this package bundles libev. Current fedora even has the same libev version. Please adjust the package to use the system provided version.

Comment 4 Sandro Bonazzola 2017-12-14 08:40:54 UTC
Rich, any chance you can help with comment #3?

Comment 5 Rich Megginson 2017-12-15 04:07:32 UTC
I tried hacking the spec file like this and building on fedora 27:

 BuildRequires: rubygem-rspec >= 3.5.0
+BuildRequires: libev-devel
 Provides: rubygem(%{gem_name}) = %{version}

...

 %setup -q -D -T -n  %{gem_name}-%{version}
 
-gem spec %{SOURCE0} -l --ruby > %{gem_name}.gemspec
+# remove libev source files from disk and gemspec
+rm -rf ext/libev
+gem spec %{SOURCE0} -l --ruby | sed 's@"ext/libev/.*".freeze, @@g' > %{gem_name}.gemspec
 
 %build

but this fails to build:

gcc -I. -I/usr/include -I/usr/include/ruby/backward -I/usr/include -I. -DRUBY_VERSION_CODE=242 -DHAVE_SYS_SELECT_H -DEV_USE_SELECT -DHAVE_POLL_H -DEV_USE_POLL -DHAVE_SYS_EPOLL_H -DEV_USE_EPOLL -DHAVE_SYS_RESOURCE_H -DHAVE_LINUX_PROCFS    -fPIC -O2 -g -fno-strict-aliasing -m64 -o cool.io_ext.o -c cool.io_ext.c
In file included from cool.io_ext.c:10:0:
ev_wrap.h:9:10: fatal error: ../libev/ev.h: No such file or directory
 #include "../libev/ev.h"
          ^~~~~~~~~~~~~~~
compilation terminated.

The next step would be to do some source code hacking to make it

 #include "libev/ev.h"

instead.

In short, it looks like this is going to be a good bit of work . . .

Comment 6 Sandro Bonazzola 2018-05-29 13:44:10 UTC
Anyone willing to continue on this?

Comment 7 Robert-André Mauchin 🐧 2019-02-16 23:56:06 UTC
(In reply to Sandro Bonazzola from comment #6)
> Anyone willing to continue on this?

You should close as DeadReview and open a new bug for your SPEC. CC me for Review.

Comment 8 Package Review 2021-03-04 00:45:30 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 9 Package Review 2021-04-04 00:45:23 UTC
This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.


Note You need to log in before you can comment on or make changes to this bug.