Bug 1374278

Summary:	rpc/xdr: generated files are filtered with a sed extended regex
Product:	[Community] GlusterFS	Reporter:	Kaleb KEITHLEY <kkeithle>
Component:	build	Assignee:	Kaleb KEITHLEY <kkeithle>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.9	CC:	bugs, ndevos
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1374280 (view as bug list)		Environment:
Last Closed:	2016-12-06 05:11:06 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1330604, 1377341
Bug Blocks:

Description Kaleb KEITHLEY 2016-09-08 11:45:09 UTC

Description of problem:

Extended regex handling is enabled with -r command line option on linux.

NetBSD and FreeBSD use -E, but also provide -r for compatibility.

Mac OS X only accepts -E. As a result, building on Mac OS fails early. (There may be other issues with building on Mac OS.)

In any event, it's possible to do the job with an ordinary regex, extended regex isn't necessary.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Worker Ant 2016-09-08 12:06:52 UTC

REVIEW: http://review.gluster.org/15427 (rpc/xdr: use ordinary regex to sed filter generated files) posted (#1) for review on release-3.9 by Kaleb KEITHLEY (kkeithle)

Comment 2 Worker Ant 2016-09-08 12:17:39 UTC

REVIEW: http://review.gluster.org/15427 (rpc/xdr: use ordinary regex to sed filter generated files) posted (#2) for review on release-3.9 by Kaleb KEITHLEY (kkeithle)

Comment 3 Worker Ant 2016-09-09 00:58:20 UTC

REVIEW: http://review.gluster.org/15427 (rpc/xdr: use ordinary regex to sed filter generated files) posted (#3) for review on release-3.9 by Kaleb KEITHLEY (kkeithle)

Comment 4 Worker Ant 2016-09-12 09:13:27 UTC

COMMIT: http://review.gluster.org/15427 committed in release-3.9 by Niels de Vos (ndevos) 
------
commit 0665f1fc689501024af523ff79a2413614267ef7
Author: Kaleb S. KEITHLEY <kkeithle>
Date:   Thu Sep 8 08:04:56 2016 -0400

    rpc/xdr: use ordinary regex to sed filter generated files
    
    Versus an extended regex
    
    While NetBSD and FreeBSD's sed has compat -r command line option,
    Mac OS X's sed does not.
    
    And there's no need to use an extended regex here; avoiding extra
    logic to determine whether running on Linux or *BSD.
    
    Change-Id: I6089f994f6c4f50eb353fc018b1b678ec93d6626
    BUG: 1374278
    Signed-off-by: Kaleb S. KEITHLEY <kkeithle>
    Reviewed-on: http://review.gluster.org/15427
    Smoke: Gluster Build System <jenkins.org>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.org>
    Reviewed-by: Niels de Vos <ndevos>