Bug 1374728

Summary: /var/run/redis and /usr/lib/tmpfiles/redis.conf not used
Product: [Fedora] Fedora Reporter: Remi Collet <rcollet>
Component: redisAssignee: Alan Pevec <apevec>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: apevec, aschultz, fabian.deutsch, fedora, fpercoco, hguemar, i, jal233, karlthered
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-02-20 12:54:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Proposed restore of tmpfiles
none
Proposed restore of tmpfiles
none
Install tmpfiles and /run/redis for legacy configurations karlthered: review+

Description Remi Collet 2016-09-09 13:26:32 UTC
/var/run/redis is only needed with sysinit to store pid files.
It is not used with systemd.

Comment 2 Alex Schultz 2016-11-04 22:47:30 UTC
Just to add a note on this, /var/run/redis is and could still be used for a local unix socket. I think this needs to get fixed via the systemd unit file though. https://bugs.launchpad.net/tripleo/+bug/1639356

Comment 3 Alan Pevec 2016-11-04 23:02:22 UTC
For posterity, this change was bundled in this cleanup:
http://pkgs.fedoraproject.org/cgit/rpms/redis.git/commit/?id=6844759f706ea883f7e9e6d265dc64a490c5bceb

This broke puppet-redis which is configuring unixsocket by default, in a default location /var/run/redis/ covered by SELinux policy.

I propose to revert part of it and restore tmpfiles back into RPM, to support legacy configurations because this can be seen as a regression for existing installations of redis.

Comment 4 Alan Pevec 2016-11-04 23:16:34 UTC
Created attachment 1217532 [details]
Proposed restore of tmpfiles

Followup patch with the proposed partial revert.

Comment 5 Alan Pevec 2016-11-04 23:22:51 UTC
Created attachment 1217533 [details]
Proposed restore of tmpfiles

Now with proper changelog and Release bump

Comment 6 Alan Pevec 2016-11-04 23:37:40 UTC
Still not working, after rpm installation /run/redis/ is not there, it needs reboot or  systemd-tmpfiles --create in %post

Comment 7 Alan Pevec 2016-11-04 23:50:47 UTC
Created attachment 1217535 [details]
Install tmpfiles and /run/redis for legacy configurations

Comment 8 Alan Pevec 2016-11-05 00:34:45 UTC
For RDO I've built it in CBS http://cbs.centos.org/koji/buildinfo?buildID=13831

Please review and push this to Fedora distgit!

Comment 9 Haïkel Guémar 2017-02-20 12:54:43 UTC
Patch backported in rawhide.