Bug 1374728 - /var/run/redis and /usr/lib/tmpfiles/redis.conf not used
Summary: /var/run/redis and /usr/lib/tmpfiles/redis.conf not used
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: redis
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Alan Pevec
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-09 13:26 UTC by Remi Collet
Modified: 2020-04-07 15:21 UTC (History)
9 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2017-02-20 12:54:43 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Proposed restore of tmpfiles (1.61 KB, patch)
2016-11-04 23:16 UTC, Alan Pevec
no flags Details | Diff
Proposed restore of tmpfiles (2.14 KB, patch)
2016-11-04 23:22 UTC, Alan Pevec
no flags Details | Diff
Install tmpfiles and /run/redis for legacy configurations (3.49 KB, patch)
2016-11-04 23:50 UTC, Alan Pevec
karlthered: review+
Details | Diff

Description Remi Collet 2016-09-09 13:26:32 UTC
/var/run/redis is only needed with sysinit to store pid files.
It is not used with systemd.

Comment 2 Alex Schultz 2016-11-04 22:47:30 UTC
Just to add a note on this, /var/run/redis is and could still be used for a local unix socket. I think this needs to get fixed via the systemd unit file though. https://bugs.launchpad.net/tripleo/+bug/1639356

Comment 3 Alan Pevec 2016-11-04 23:02:22 UTC
For posterity, this change was bundled in this cleanup:
http://pkgs.fedoraproject.org/cgit/rpms/redis.git/commit/?id=6844759f706ea883f7e9e6d265dc64a490c5bceb

This broke puppet-redis which is configuring unixsocket by default, in a default location /var/run/redis/ covered by SELinux policy.

I propose to revert part of it and restore tmpfiles back into RPM, to support legacy configurations because this can be seen as a regression for existing installations of redis.

Comment 4 Alan Pevec 2016-11-04 23:16:34 UTC
Created attachment 1217532 [details]
Proposed restore of tmpfiles

Followup patch with the proposed partial revert.

Comment 5 Alan Pevec 2016-11-04 23:22:51 UTC
Created attachment 1217533 [details]
Proposed restore of tmpfiles

Now with proper changelog and Release bump

Comment 6 Alan Pevec 2016-11-04 23:37:40 UTC
Still not working, after rpm installation /run/redis/ is not there, it needs reboot or  systemd-tmpfiles --create in %post

Comment 7 Alan Pevec 2016-11-04 23:50:47 UTC
Created attachment 1217535 [details]
Install tmpfiles and /run/redis for legacy configurations

Comment 8 Alan Pevec 2016-11-05 00:34:45 UTC
For RDO I've built it in CBS http://cbs.centos.org/koji/buildinfo?buildID=13831

Please review and push this to Fedora distgit!

Comment 9 Haïkel Guémar 2017-02-20 12:54:43 UTC
Patch backported in rawhide.


Note You need to log in before you can comment on or make changes to this bug.