Bug 1375993

Summary:	Review Request: python-flufl-i18n - A high level API for Python internationalization
Product:	[Fedora] Fedora	Reporter:	Aurelien Bompard <aurelien>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, panemade, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-10-18 11:30:18 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Aurelien Bompard 2016-09-14 12:18:36 UTC

Spec URL: https://abompard.fedorapeople.org/reviews/flufl.i18n/python-flufl.i18n.spec
SRPM URL: https://abompard.fedorapeople.org/reviews/flufl.i18n/python-flufl.i18n-1.1.3-1.fc23.src.rpm
Description: 
The ``flufl.i18n`` library provides a convenient API for managing translation
contexts in Python applications. It provides facilities not only for
single-context applications like command line scripts, but also more
sophisticated management of multiple-context applications such as Internet
servers.

Fedora Account System Username: abompard

Comment 1 Zbigniew Jędrzejewski-Szmek 2016-10-05 03:45:10 UTC

Same comments as in
https://bugzilla.redhat.com/show_bug.cgi?id=1376001#c1 and
https://bugzilla.redhat.com/show_bug.cgi?id=1375999#c1.

Comment 2 Aurelien Bompard 2016-10-05 09:24:05 UTC

I renamed the package and used macros for the summary and description. Thanks.

Spec URL: https://abompard.fedorapeople.org/reviews/flufl.i18n/python-flufl-i18n.spec
SRPM URL: https://abompard.fedorapeople.org/reviews/flufl.i18n/python-flufl-i18n-1.1.3-1.fc23.src.rpm

Comment 3 Zbigniew Jędrzejewski-Szmek 2016-10-09 14:15:18 UTC

Again, a bunch of sphinx files in site-packages.

Comment 4 Aurelien Bompard 2016-10-09 15:51:26 UTC

Fixed, thanks again.

Spec URL: https://abompard.fedorapeople.org/reviews/flufl.i18n/python-flufl-i18n.spec
SRPM URL: https://abompard.fedorapeople.org/reviews/flufl.i18n/python-flufl-i18n-1.1.3-1.fc23.src.rpm

Comment 5 Zbigniew Jędrzejewski-Szmek 2016-10-10 01:56:19 UTC

conf.py should be deleted from site-packages too.

+ package name is OK
+ latest version
+ license is acceptable (LGPLv3+)
+ license is specified correctly
+ python packaging template is used
+ %python_provide is used
+ provides/requires are OK
+ builds and installs OK

Package is APPROVED.

Comment 6 Patrick Uiterwijk 2016-10-11 12:28:59 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-flufl-i18n

Comment 7 Fedora Update System 2016-10-14 04:55:38 UTC

python-flufl-i18n-1.1.3-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-14e09ad46e

Comment 8 Fedora Update System 2016-10-18 11:30:18 UTC

python-flufl-i18n-1.1.3-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.