Bug 1376001

Summary:	Review Request: python-flufl-lock - NFS-safe file locking with timeouts for POSIX systems
Product:	[Fedora] Fedora	Reporter:	Aurelien Bompard <aurelien>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-10-18 11:30:25 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Aurelien Bompard 2016-09-14 12:33:57 UTC

Spec URL: https://abompard.fedorapeople.org/reviews/flufl.lock/python-flufl.lock.spec
SRPM URL: https://abompard.fedorapeople.org/reviews/flufl.lock/python-flufl.lock-2.4.1-1.fc23.src.rpm
Description:
The flufl.lock library provides an NFS-safe file-based locking algorithm
influenced by the GNU/Linux "open(2)" manpage, under the description of the
"O_EXCL" option.

Fedora Account System Username: abompard

Comment 1 Zbigniew Jędrzejewski-Szmek 2016-10-05 03:38:45 UTC

"." should be replaced with "-" in the package name [https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuidelines#Separators].

You can replace the second and subsequent Summary texts with %{summary}, no need to repeat.

Looks good otherwise.

Comment 2 Aurelien Bompard 2016-10-05 09:05:08 UTC

I renamed the package, and use macros for the summary and description. Thanks.

Spec URL: https://abompard.fedorapeople.org/reviews/flufl.lock/python-flufl-lock.spec
SRPM URL: https://abompard.fedorapeople.org/reviews/flufl.lock/python-flufl-lock-2.4.1-1.fc23.src.rpm

Comment 3 Zbigniew Jędrzejewski-Szmek 2016-10-09 14:10:22 UTC

+ /usr/bin/python2 setup.py test
running test
running egg_info
writing flufl.lock.egg-info/PKG-INFO
writing namespace_packages to flufl.lock.egg-info/namespace_packages.txt
writing top-level names to flufl.lock.egg-info/top_level.txt
writing dependency_links to flufl.lock.egg-info/dependency_links.txt
reading manifest file 'flufl.lock.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no previously-included files found matching '.gitignore'
writing manifest file 'flufl.lock.egg-info/SOURCES.txt'
running build_ext
test_retries (flufl.lock.tests.test_lockfile.ErrnoRetryTests) ... FAIL
test_retry_errno_api (flufl.lock.tests.test_lockfile.ErrnoRetryTests) ... ok
/home/zbyszek/rpmbuild/BUILD/flufl.lock-2.4.1/flufl/lock/README.rst
Doctest: README.rst ... ok
/home/zbyszek/rpmbuild/BUILD/flufl.lock-2.4.1/flufl/lock/docs/using.rst
Doctest: using.rst ... ok

======================================================================
FAIL: test_retries (flufl.lock.tests.test_lockfile.ErrnoRetryTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/zbyszek/rpmbuild/BUILD/flufl.lock-2.4.1/flufl/lock/tests/test_lockfile.py", line 103, in test_retries
    self.assertEqual(self._retry_count, 3)
AssertionError: 0 != 3

----------------------------------------------------------------------
Ran 4 tests in 28.614s

FAILED (failures=1)

This is in a local build on F25.

Nevertheless, it builds find in F25, rawhide mock: http://koji.fedoraproject.org/koji/taskinfo?taskID=16015449,  http://koji.fedoraproject.org/koji/taskinfo?taskID=16015457.

rpmlint says:
python2-flufl-lock.noarch: W: spelling-error %description -l en_US manpage -> manage, man page, man-page
python3-flufl-lock.noarch: W: spelling-error %description -l en_US manpage -> manage, man page, man-page
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
"man page" is a better spelling.


Similarly to python-flufl-bounce, there's a bunch of sphinx files in site-packages.

Comment 4 Aurelien Bompard 2016-10-09 15:50:41 UTC

I fixed those issues, thanks. I can't reproduce the test failure though.

Spec URL: https://abompard.fedorapeople.org/reviews/flufl.lock/python-flufl-lock.spec
SRPM URL: https://abompard.fedorapeople.org/reviews/flufl.lock/python-flufl-lock-2.4.1-1.fc23.src.rpm

Comment 5 Zbigniew Jędrzejewski-Szmek 2016-10-10 01:47:03 UTC

What kernel are you using? I have 
4.8.0-0.rc7.git0.1.fc25.x86_64 here, it might be related. The strange thing is that only python2 fails (python-2.7.12-6.fc25.x86_64).

conf.py should be deleted from site-packages too.

+ package name is OK
+ latest version
+ license is acceptable (LGPLv3+)
+ license is specified correctly
+ python packaging template is used
+ %python_provide is used
+ provides/requires are OK
+ builds and installs OK

Package is APPROVED.

Comment 6 Patrick Uiterwijk 2016-10-11 12:27:14 UTC

Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-flufl-lock

Comment 7 Fedora Update System 2016-10-14 04:55:44 UTC

python-flufl-lock-2.4.1-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-91bdd97aca

Comment 8 Fedora Update System 2016-10-18 11:30:25 UTC

python-flufl-lock-2.4.1-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.