Bug 1377069
Summary: | DeprecationWarning: vdscli uses xmlrpc. since ovirt 3.6 xmlrpc is deprecated, please use vdsm.jsonrpcvdscli | ||
---|---|---|---|
Product: | [oVirt] vdsm | Reporter: | Aleksey <aleksey.maksimov> |
Component: | Tools | Assignee: | Nir Soffer <nsoffer> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Jiri Belka <jbelka> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 4.18.12 | CC: | bugs, fdeutsch, mgoldboi, nsoffer, oourfali, tnisan |
Target Milestone: | ovirt-4.0.5 | Keywords: | Regression |
Target Release: | 4.18.15 | Flags: | rule-engine:
ovirt-4.0.z+
rule-engine: blocker+ mgoldboi: planning_ack+ rule-engine: devel_ack+ pstehlik: testing_ack+ |
Hardware: | x86_64 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2017-01-18 07:40:19 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | Infra | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 1372237 |
Description
Aleksey
2016-09-18 07:48:10 UTC
Reported on user list: http://lists.ovirt.org/pipermail/users/2016-September/042813.html Note that vdsClient is *not* supported, and will be removed in the future version. The best way to automated vdsm is using vdscli library, used by vdsClient. Note that this module is also deprecated and we are working on replacing it with a jsonrpc library, but this work is not completed yet. Regardless, these warnings are meant for developers and should never be used in vdsClient. This patch removes the warnings, replacing them with logging to the devel logger: https://gerrit.ovirt.org/62209. This patch fixes this issue, avoiding unexpected messages in vdsClient: https://gerrit.ovirt.org/64099 This regression introduced in: https://gerrit.ovirt.org/60318 Moving to infra as the regression was introduced by them What's the regression here? The fact we have warnings? From what it seems this is what Aleksey is complaining about, I guess this behavior was intentional so in that case it can be closed as NOTABUG but since infra team introduced this change they are the ones to decide how to proceed :) We will decide indeed. Removing the Regression keyword anyway. (In reply to Tal Nisan from comment #5) > From what it seems this is what Aleksey is complaining about, I guess this > behavior was intentional If this behaviour was intentional, this is even worse. > so in that case it can be closed as NOTABUG but > since infra team introduced this change they are the ones to decide how to > proceed :) No, we cannot close this, we just need to fix this quickly. See http://gerrit.ovirt.org/64100. (We don't need the other patches, this patch is enough) Showing developer warnings to users is *not* ok. This is rude and irresponsible behavior. Developer warnings are for developers; they should control if warnings are displayed or not. The patch that introduced this regression configured the warnings.filter in a library module, so the developer of the program importing this module have no way to disable the warnings. And this change as backported to 4.0, braking existing software. (In reply to Oved Ourfali from comment #6) > We will decide indeed. > Removing the Regression keyword anyway. This is a regression, do not remove it. Assigning to Nir based on the above. Nir - please set the target according to what you see fit. This bug report has Keywords: Regression or TestBlocker. Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP. Testing this change: Run any vdsClient command, the warning mentioned in the description should be displayed. Can also be verified on hosted engine setup: hosted-engine --set-maintenance --mode=none ok, vdsm-4.18.15-1.el7ev.x86_64 no more 'DeprecationWarning' with current vdsm rpm |