Description of problem:
Version-Release number of selected component (if applicable):
oVirt Engine Version: 4.0.3-1.el7.centos
Every time I call the commands:
* hosted-engine --set-maintenance --mode=global
* hosted-engine --set-maintenance --mode=none
The message appears:
/usr/lib/python2.7/site-packages/ovirt_hosted_engine_ha/lib/storage_backends.py:15: DeprecationWarning: vdscli uses xmlrpc. since ovirt 3.6 xmlrpc is deprecated, please use vdsm.jsonrpcvdscli
Do not show DeprecationWarning.
This message (DeprecationWarning) prevents normal tracking the status of execution of commands in my custom automation scripts, for example in my script for HostedEngine backup.
Reported on user list:
Note that vdsClient is *not* supported, and will be removed in the future version.
The best way to automated vdsm is using vdscli library, used by vdsClient.
Note that this module is also deprecated and we are working on replacing it with
a jsonrpc library, but this work is not completed yet.
Regardless, these warnings are meant for developers and should never be used in
This patch removes the warnings, replacing them with logging to the devel logger:
This patch fixes this issue, avoiding unexpected messages in vdsClient:
This regression introduced in:
Moving to infra as the regression was introduced by them
What's the regression here?
The fact we have warnings?
From what it seems this is what Aleksey is complaining about, I guess this behavior was intentional so in that case it can be closed as NOTABUG but since infra team introduced this change they are the ones to decide how to proceed :)
We will decide indeed.
Removing the Regression keyword anyway.
(In reply to Tal Nisan from comment #5)
> From what it seems this is what Aleksey is complaining about, I guess this
> behavior was intentional
If this behaviour was intentional, this is even worse.
> so in that case it can be closed as NOTABUG but
> since infra team introduced this change they are the ones to decide how to
> proceed :)
No, we cannot close this, we just need to fix this quickly.
(We don't need the other patches, this patch is enough)
Showing developer warnings to users is *not* ok. This is rude and irresponsible
Developer warnings are for developers; they should control if warnings are
displayed or not.
The patch that introduced this regression configured the warnings.filter
in a library module, so the developer of the program importing this module
have no way to disable the warnings.
And this change as backported to 4.0, braking existing software.
(In reply to Oved Ourfali from comment #6)
> We will decide indeed.
> Removing the Regression keyword anyway.
This is a regression, do not remove it.
Assigning to Nir based on the above.
Nir - please set the target according to what you see fit.
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.
Testing this change:
Run any vdsClient command, the warning mentioned in the description should be
Can also be verified on hosted engine setup:
hosted-engine --set-maintenance --mode=none
no more 'DeprecationWarning' with current vdsm rpm