Bug 1377551

Summary: RFE: backport unix sockets support from spice-server upstream
Product: Red Hat Enterprise Linux 7 Reporter: Fangge Jin <fjin>
Component: spiceAssignee: Default Assignee for SPICE Bugs <rh-spice-bugs>
Status: CLOSED ERRATA QA Contact: SPICE QE bug list <spice-qe-bugs>
Severity: medium Docs Contact: Yehuda Zimmerman <yzimmerm>
Priority: high    
Version: 7.3CC: cfergeau, dblechte, dyuan, fjin, fziglio, juzhou, mtessun, mzhan, rduda, tpelka, tzheng, xiaodwan, xuzhang
Target Milestone: rcKeywords: FutureFeature
Target Release: 7.4   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: spice-0.12.8-1.el7 Doc Type: If docs needed, set a value
Doc Text:
No documentation needed.
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-01 16:06:08 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1388947    
Bug Blocks: 1335832, 1395265    

Description Fangge Jin 2016-09-20 05:57:16 UTC
Description of problem:
Libvirt supports spice graphic to listen on a unix socket since RHEL7.3, but this function is not supported by spice in RHEL7.3.

Version-Release number of selected component (if applicable):
spice-server-0.12.4-18.el7.x86_64
qemu-kvm-rhev-2.6.0-25.el7.x86_64
libvirt-2.0.0-8.el7.x86_64

How reproducible:
Always

Steps to Reproduce:
1.Configure a guest to use spice graphic and listen type='socket':
  # virsh dumpxml rhel7.3-0817
  ...
    <graphics type='spice'>
      <listen type='socket'/>
    </graphics>

2.Start guest
  # virsh start rhel7.3-0817
  error: Failed to start domain rhel7.3-0817
  error: unsupported configuration: unix socket for spice graphics are not  supported with this QEMU


Actual results:
Guest failed to start

Expected results:
Guest can start sucessfully

Additional info:
The upstream spice patch:
commit 5365caeaae537f564d160936e60f71b2dc964ad1
Author: Marc-André Lureau <marcandre.lureau>
Date:   Thu Jan 8 16:05:57 2015 +0100

    reds: add Unix socket support
    
    Learn to listen on a Unix address. In this case, the connection is plain
    only (non-tls).

Comment 2 Christophe Fergeau 2016-09-20 07:38:56 UTC
(In reply to JinFangge from comment #0)
> Description of problem:
> Libvirt supports spice graphic to listen on a unix socket since RHEL7.3, but
> this function is not supported by spice in RHEL7.3.

What is your ultimate usecase for having this feature? I understand it's missing in RHEL7.3, but knowing you would need that feature in order to achieve X and Y would be useful to move this RFE forward.

Comment 3 Xuesong Zhang 2016-09-20 08:26:09 UTC
(In reply to Christophe Fergeau from comment #2)
> (In reply to JinFangge from comment #0)
> > Description of problem:
> > Libvirt supports spice graphic to listen on a unix socket since RHEL7.3, but
> > this function is not supported by spice in RHEL7.3.
> 
> What is your ultimate usecase for having this feature? I understand it's
> missing in RHEL7.3, but knowing you would need that feature in order to
> achieve X and Y would be useful to move this RFE forward.

hi, Christophe,

Please see the description in BZ 1335832, and needinfo phrdina@ if you still have any questions about this feature. 
Since we are the QE of libvirt component, we can not verify the libvirt BZ1335832 with the downstream spice, then file one spice bug for tracking in RHEL7.4.

Comment 5 Radek Duda 2017-04-13 14:02:41 UTC
I wanted to verify this using
libvirt-3.2.0-2.el7.x86_64
spice-server-0.12.8-1.el7.x86_64
qemu-kvm-rhev-2.6.0-28.el7_3.9.x86_64

but only reproduced the problem:

error: Failed to start domain rhel7.2-2test
error: unsupported configuration: unix socket for spice graphics are not supported with this QEMU

Is there still some part missing?

Comment 6 Radek Duda 2017-04-13 15:00:40 UTC
Sorry I overlooked relevant qemu-kvm-rhev version

Comment 9 errata-xmlrpc 2017-08-01 16:06:08 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2017:1866