Bug 1377733
| Summary: | Review Request: systemd-bootchart - Boot performance graphing tool | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Alessandro Locati <fale> |
| Component: | Package Review | Assignee: | Igor Gnatenko <ignatenko> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, zbyszek |
| Target Milestone: | --- | Flags: | ignatenko:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-10-09 02:53:39 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabio Alessandro Locati
2016-09-20 13:40:08 UTC
- Use %{_unitdir}
- Use %make_build
- Add special systemd macro in %post* triggers
- Use %{?systemd_requires}
Thanks Igor :). SRPM: https://fale.fedorapeople.org/rpms/systemd-bootchart-231-2.fc24.src.rpm SPEC: https://fale.fedorapeople.org/rpms/systemd-bootchart.spec > BuildRequires: systemd-units > BuildRequires: systemd-devel BuildRequires: pkgconfig(libsystemd) > %config(noreplace) /etc/systemd/bootchart.conf %config(noreplace) %{_sysconfdir}/systemd/bootchart.conf > /usr/lib/systemd/systemd-bootchart %{_unitdir}/../%{name} > %{_mandir}/man1/systemd-bootchart.1.gz %{_mandir}/man1/%{name}.1* > %{_mandir}/man5/bootchart.conf.5.gz %{_mandir}/man5/bootchart.conf.5* > %{_mandir}/man5/bootchart.conf.d.5.gz %{_mandir}/man5/bootchart.conf.d.5* * Missing BuildRequires: gcc All this issues are easy to fix during import, so approving. Also: BuildRequires: systemd-units → not necessary, you have BR:systemd-devel already Please put something in description that explains to newcomers what this package does: e.g. "This package provides a binary which can be started during boot early boot to capture informations about processes and services launched during bootup. Resource utilization and process information are collected during the boot process and are later rendered in an SVG chart. The timings for each services are displayed separately." Looks great otherwise. Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/systemd-bootchart systemd-bootchart-231-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-2f0fcabe02 Sorry, yet another request: Please add Obsoletes: systemd < 231, so that this package is automatically installed when upgrading both packages. Speaking in fedora-devel channel, the consensus was that it's probably better and safer to have a soft dependency like Recommend on systemd pointing to this package. I'll open a bug against systemd to discuss this point tomorrow (bugzilla is "not great" from the smartphone). Hi, I was travelling the last few days, I couldn't participate in the conversation. I'm fine with adding a Recommend. This package is tiny, so this shouldn't be an issue. I'll add it on systemd-udev, since this is useful on "real" systems. http://pkgs.fedoraproject.org/cgit/rpms/systemd.git/commit/?h=master&id=ef73cc0d30dc1cd4c58ffc368ab0671daccf76fe Sorry, I lost your comment :/. Nice, thanks :) systemd-bootchart-231-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. |