Bug 1377733 - Review Request: systemd-bootchart - Boot performance graphing tool
Summary: Review Request: systemd-bootchart - Boot performance graphing tool
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Igor Gnatenko
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-20 13:40 UTC by Fabio Alessandro Locati
Modified: 2016-10-09 02:53 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-10-09 02:53:39 UTC
Type: ---
Embargoed:
ignatenko: fedora-review+


Attachments (Terms of Use)

Description Fabio Alessandro Locati 2016-09-20 13:40:08 UTC
Spec URL: https://fale.fedorapeople.org/rpms/systemd-bootchart.spec
SRPM URL: https://fale.fedorapeople.org/rpms/systemd-bootchart-231-1.fc24.src.rpm
Description: Boot performance graphing tool
Fedora Account System Username: fale

Comment 1 Igor Gnatenko 2016-09-20 17:07:54 UTC
- Use %{_unitdir}
- Use %make_build
- Add special systemd macro in %post* triggers
- Use %{?systemd_requires}

Comment 3 Igor Gnatenko 2016-09-21 09:35:09 UTC
> BuildRequires: systemd-units
> BuildRequires: systemd-devel
BuildRequires: pkgconfig(libsystemd)

> %config(noreplace) /etc/systemd/bootchart.conf
%config(noreplace) %{_sysconfdir}/systemd/bootchart.conf

> /usr/lib/systemd/systemd-bootchart
%{_unitdir}/../%{name}

> %{_mandir}/man1/systemd-bootchart.1.gz
%{_mandir}/man1/%{name}.1*
> %{_mandir}/man5/bootchart.conf.5.gz
%{_mandir}/man5/bootchart.conf.5*
> %{_mandir}/man5/bootchart.conf.d.5.gz
%{_mandir}/man5/bootchart.conf.d.5*

* Missing BuildRequires: gcc

All this issues are easy to fix during import, so approving.

Comment 4 Zbigniew Jędrzejewski-Szmek 2016-09-21 11:54:59 UTC
Also:
BuildRequires: systemd-units → not necessary, you have BR:systemd-devel already

Please put something in description that explains to newcomers what this package does: e.g. "This package provides a binary which can be started during boot early boot to capture informations about processes and services launched during bootup. Resource utilization and process information are collected during the boot process and are later rendered in an SVG chart. The timings for each services are displayed separately."

Looks great otherwise.

Comment 5 Gwyn Ciesla 2016-09-21 12:26:08 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/systemd-bootchart

Comment 6 Fedora Update System 2016-09-22 09:55:10 UTC
systemd-bootchart-231-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-2f0fcabe02

Comment 7 Zbigniew Jędrzejewski-Szmek 2016-09-22 12:07:53 UTC
Sorry, yet another request:
Please add Obsoletes: systemd < 231, so that this package is automatically installed when upgrading both packages.

Comment 9 Fabio Alessandro Locati 2016-09-25 19:07:16 UTC
Speaking in fedora-devel channel, the consensus was that it's probably better and safer to have a soft dependency like Recommend on systemd pointing to this package. I'll open a bug against systemd to discuss this point tomorrow (bugzilla is "not great" from the smartphone).

Comment 10 Zbigniew Jędrzejewski-Szmek 2016-09-26 19:17:23 UTC
Hi,
I was travelling the last few days, I couldn't participate in the conversation.

I'm fine with adding a Recommend. This package is tiny, so this shouldn't be an issue. I'll add it on systemd-udev, since this is useful on "real" systems.

http://pkgs.fedoraproject.org/cgit/rpms/systemd.git/commit/?h=master&id=ef73cc0d30dc1cd4c58ffc368ab0671daccf76fe

Comment 11 Fabio Alessandro Locati 2016-09-28 09:54:34 UTC
Sorry,
I lost your comment :/. Nice, thanks :)

Comment 12 Fedora Update System 2016-10-09 02:53:39 UTC
systemd-bootchart-231-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.