Bug 1378918

Summary: virt-convert not recognizing buses different than SCSI and IDE
Product: [Community] Virtualization Tools Reporter: ricky_r <ricrav>
Component: virt-managerAssignee: Cole Robinson <crobinso>
Status: CLOSED WONTFIX QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: berrange, crobinso, gscrivan
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-01-26 18:25:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
patch file to apply to virtconv/ovf.py
none
ovf file specifying a SATA bus, for testing none

Description ricky_r 2016-09-23 13:59:31 UTC
Description of problem:
Virt-convert does not recognize any disk bus other than SCSI and IDE. In virtconv/ovf.py function _import_file() only checks for ResourceType numbers corresponding to SCSI and IDE, and forces a bus that is neither of them to be IDE in the xml file it generates. 

Version-Release number of selected component (if applicable):
All versions including the latest one, 1.4.0

How reproducible:
In the archive in attachment I included:
- the patch for SATA buses
- an ovf file for testing
- the current ovf.py file

Steps to Reproduce:
1. apply patch: $ patch virtconv/ovf.py < patch.diff
2. run virt-convert: $ ./virt-convert LinuxDebianJessie.ovf --destination . --dry-run --print-xml

Actual results (with current code):
[...]
<disk type="file" device="disk">
      <driver name="qemu" type="raw"/>
      <source file="test/./LinuxDebianJessie-disk1.raw"/>
      <target dev="hda" bus="ide"/>
</disk>


Expected results (with patched code):
[...]
<disk type="file" device="disk">
      <driver name="qemu" type="raw"/>
      <source file="prova/./LinuxDebianJessie-disk1.raw"/>
      <target dev="sda" bus="sata"/>
</disk>

Comment 1 ricky_r 2016-09-23 14:03:23 UTC
Created attachment 1204167 [details]
patch file to apply to virtconv/ovf.py

Comment 2 ricky_r 2016-09-23 14:04:30 UTC
Created attachment 1204168 [details]
ovf file specifying a SATA bus, for testing

Comment 3 ricky_r 2016-09-23 14:05:09 UTC
Comment on attachment 1204168 [details]
ovf file specifying a SATA bus, for testing

Remove .txt ending once downloaded.

Comment 4 Cole Robinson 2020-01-26 18:25:04 UTC
Sorry for never responding, but virt-convert has been removed upstream. See discussion here: https://www.redhat.com/archives/virt-tools-list/2019-June/msg00117.html

Your best bet is to extract the disk image, and pass it to virt-install or virt-manager import install.
virt-convert was never particularly good at anything beyond that anyways
Closing as WONTFIX