Bug 1378918 - virt-convert not recognizing buses different than SCSI and IDE
Summary: virt-convert not recognizing buses different than SCSI and IDE
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Virtualization Tools
Classification: Community
Component: virt-manager
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Cole Robinson
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-09-23 13:59 UTC by ricky_r
Modified: 2020-01-26 18:25 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-01-26 18:25:04 UTC

Attachments (Terms of Use)
patch file to apply to virtconv/ovf.py (775 bytes, patch)
2016-09-23 14:03 UTC, ricky_r 		no flags Details | Diff
ovf file specifying a SATA bus, for testing (13.18 KB, text/plain)
2016-09-23 14:04 UTC, ricky_r 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Description ricky_r 2016-09-23 13:59:31 UTC 
Description of problem:
Virt-convert does not recognize any disk bus other than SCSI and IDE. In virtconv/ovf.py function _import_file() only checks for ResourceType numbers corresponding to SCSI and IDE, and forces a bus that is neither of them to be IDE in the xml file it generates. 

Version-Release number of selected component (if applicable):
All versions including the latest one, 1.4.0

How reproducible:
In the archive in attachment I included:
- the patch for SATA buses
- an ovf file for testing
- the current ovf.py file

Steps to Reproduce:
1. apply patch: $ patch virtconv/ovf.py < patch.diff
2. run virt-convert: $ ./virt-convert LinuxDebianJessie.ovf --destination . --dry-run --print-xml

Actual results (with current code):
[...]
<disk type="file" device="disk">
      <driver name="qemu" type="raw"/>
      <source file="test/./LinuxDebianJessie-disk1.raw"/>
      <target dev="hda" bus="ide"/>
</disk>


Expected results (with patched code):
[...]
<disk type="file" device="disk">
      <driver name="qemu" type="raw"/>
      <source file="prova/./LinuxDebianJessie-disk1.raw"/>
      <target dev="sda" bus="sata"/>
</disk>
Comment 1 ricky_r 2016-09-23 14:03:23 UTC 
Created attachment 1204167 [details]
patch file to apply to virtconv/ovf.py
Comment 2 ricky_r 2016-09-23 14:04:30 UTC 
Created attachment 1204168 [details]
ovf file specifying a SATA bus, for testing
Comment 3 ricky_r 2016-09-23 14:05:09 UTC 
Comment on attachment 1204168 [details]
ovf file specifying a SATA bus, for testing

Remove .txt ending once downloaded.
Comment 4 Cole Robinson 2020-01-26 18:25:04 UTC 
Sorry for never responding, but virt-convert has been removed upstream. See discussion here: https://www.redhat.com/archives/virt-tools-list/2019-June/msg00117.html

Your best bet is to extract the disk image, and pass it to virt-install or virt-manager import install.
virt-convert was never particularly good at anything beyond that anyways
Closing as WONTFIX
Note You need to log in before you can comment on or make changes to this bug.