Bug 1379348

Summary:	Button edit dialog title is incorrect
Product:	Red Hat CloudForms Management Engine	Reporter:	Milan Falešník <mfalesni>
Component:	Automate	Assignee:	Patrik Kománek <pkomanek>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Dmitry Misharov <dmisharo>
Severity:	low	Docs Contact:
Priority:	medium
Version:	5.6.0	CC:	cpelland, dajohnso, dclarizi, jhardy, mkanoor, obarenbo, pkomanek, simaishi, tfitzger
Target Milestone:	GA	Keywords:	TestOnly, ZStream
Target Release:	5.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	button
Fixed In Version:	5.9.0.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1386787 1386793 1479926 (view as bug list)		Environment:
Last Closed:	2018-03-06 15:51:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	Bug
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Bug Depends On:
Bug Blocks:	1386787, 1386793, 1479926

Description Milan Falešník 2016-09-26 12:32:13 UTC

Description of problem:
When editing a custom button, the title (#explorer_title_text) of the page says "Adding a new Button" which is inconsistent and might be confusing.


Version-Release number of selected component (if applicable):
At least 5.6.2.0 and forward

Comment 2 CFME Bot 2016-10-19 02:57:12 UTC

New commit detected on ManageIQ/manageiq/euwe:
https://github.com/ManageIQ/manageiq/commit/5436ce82cc1bae453d7dcaa23153b2b9465ca0e6

commit 5436ce82cc1bae453d7dcaa23153b2b9465ca0e6
Author:     Greg McCullough <gmccullo>
AuthorDate: Mon Oct 17 10:30:14 2016 -0400
Commit:     Oleg Barenboim <chessbyte>
CommitDate: Tue Oct 18 21:53:01 2016 -0500

    Merge pull request #11578 from pkomanek/missleading_title
    
    Fixing misleading title for button edit dialog.
    (cherry picked from commit 835a62f220d602418c2fb2931893a988abc3fe66)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1379348

 app/controllers/application_controller/buttons.rb | 1 -
 app/views/shared/buttons/_ab_list.html.haml       | 4 ++--
 2 files changed, 2 insertions(+), 3 deletions(-)

Comment 3 Satoe Imaishi 2016-10-19 12:48:18 UTC

PR: https://github.com/ManageIQ/manageiq/pull/11578

Comment 6 Milan Falešník 2017-03-01 10:44:53 UTC

Verified in 5.8.0.2. It is gone now but in exchange the button create dialog now shows "Button group xyz" as title instead of "Adding a new Button". Again, confusing.

Comment 7 Patrik Kománek 2017-03-28 06:53:23 UTC

(In reply to Milan Falešník from comment #6)
> Verified in 5.8.0.2. It is gone now but in exchange the button create dialog
> now shows "Button group xyz" as title instead of "Adding a new Button".
> Again, confusing.

This PR: https://github.com/ManageIQ/manageiq-ui-classic/commit/19279f5a846b925c30df061cb4cfafa773c1aa1a broke the titles, I'm working on a fix.

Comment 8 Roman Blanco 2017-03-28 09:19:44 UTC

New fix in PR: https://github.com/ManageIQ/manageiq-ui-classic/pull/817

Comment 9 Patrik Kománek 2017-04-12 12:14:23 UTC

New fix in PR: https://github.com/ManageIQ/manageiq-ui-classic/pull/889

Comment 10 Milan Falešník 2017-05-05 11:18:12 UTC

Bumping it back on_dev as the relevant fix is still work-in-progress.

Comment 11 CFME Bot 2017-05-26 14:16:21 UTC

https://github.com/ManageIQ/manageiq/pull/15237

Comment 12 Patrik Kománek 2017-07-26 12:44:48 UTC

New fix: https://github.com/ManageIQ/manageiq-ui-classic/pull/1716

Comment 14 Milan Falešník 2017-10-11 09:58:57 UTC

Verified in 5.9.0.1