Description of problem: When editing a custom button, the title (#explorer_title_text) of the page says "Adding a new Button" which is inconsistent and might be confusing. Version-Release number of selected component (if applicable): At least 5.6.2.0 and forward
New commit detected on ManageIQ/manageiq/euwe: https://github.com/ManageIQ/manageiq/commit/5436ce82cc1bae453d7dcaa23153b2b9465ca0e6 commit 5436ce82cc1bae453d7dcaa23153b2b9465ca0e6 Author: Greg McCullough <gmccullo> AuthorDate: Mon Oct 17 10:30:14 2016 -0400 Commit: Oleg Barenboim <chessbyte> CommitDate: Tue Oct 18 21:53:01 2016 -0500 Merge pull request #11578 from pkomanek/missleading_title Fixing misleading title for button edit dialog. (cherry picked from commit 835a62f220d602418c2fb2931893a988abc3fe66) https://bugzilla.redhat.com/show_bug.cgi?id=1379348 app/controllers/application_controller/buttons.rb | 1 - app/views/shared/buttons/_ab_list.html.haml | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-)
PR: https://github.com/ManageIQ/manageiq/pull/11578
Verified in 5.8.0.2. It is gone now but in exchange the button create dialog now shows "Button group xyz" as title instead of "Adding a new Button". Again, confusing.
(In reply to Milan Falešník from comment #6) > Verified in 5.8.0.2. It is gone now but in exchange the button create dialog > now shows "Button group xyz" as title instead of "Adding a new Button". > Again, confusing. This PR: https://github.com/ManageIQ/manageiq-ui-classic/commit/19279f5a846b925c30df061cb4cfafa773c1aa1a broke the titles, I'm working on a fix.
New fix in PR: https://github.com/ManageIQ/manageiq-ui-classic/pull/817
New fix in PR: https://github.com/ManageIQ/manageiq-ui-classic/pull/889
Bumping it back on_dev as the relevant fix is still work-in-progress.
https://github.com/ManageIQ/manageiq/pull/15237
New fix: https://github.com/ManageIQ/manageiq-ui-classic/pull/1716
Verified in 5.9.0.1